Fix ClassCastException when reflecting on globbed import

apple · May 28, 2024 · f307a45 · f307a45
1 parent 5b9e27d
commit f307a45
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/pkl-core/src/main/java/org/pkl/core/runtime/VmTyped.java b/pkl-core/src/main/java/org/pkl/core/runtime/VmTyped.java
@@ -23,7 +23,7 @@
 import org.pkl.core.Composite;
 import org.pkl.core.PModule;
 import org.pkl.core.PObject;
-import org.pkl.core.ast.expression.unary.ImportNode;
+import org.pkl.core.ast.expression.unary.AbstractImportNode;
 import org.pkl.core.ast.member.ObjectMember;
 import org.pkl.core.util.EconomicMaps;
 import org.pkl.core.util.LateInit;
@@ -105,7 +105,7 @@ public VmMap getImports() {
         assert memberNode != null; // import is never a constant
         builder.add(
             member.getName().toString(),
-            ((ImportNode) memberNode.getBodyNode()).getImportUri().toString());
+            ((AbstractImportNode) memberNode.getBodyNode()).getImportUri().toString());
       }
     }
     return builder.build();

diff --git a/pkl-core/src/test/files/LanguageSnippetTests/input/api/reflect4.pkl b/pkl-core/src/test/files/LanguageSnippetTests/input/api/reflect4.pkl
@@ -0,0 +1,12 @@
+amends ".../snippetTest.pkl"
+
+import "pkl:reflect"
+import* "reflect*.pkl"
+
+local mod = reflect.Module(this)
+
+examples {
+  ["Reflecting globbed import"] {
+    mod.imports.keys == Set("reflect", "reflect*")
+  }
+}
diff --git a/pkl-core/src/test/files/LanguageSnippetTests/output/api/reflect4.pcf b/pkl-core/src/test/files/LanguageSnippetTests/output/api/reflect4.pcf
@@ -0,0 +1,5 @@
+examples {
+  ["Reflecting globbed import"] {
+    true
+  }
+}