This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
Expose virtual method lookup and this ptr adjustment. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should land on llvm.org/master first, unless it depends on code on GitHub.com/apple/swift-clang. If it does, it should be committed to |
|
@hyp I think that this can go into master directly. I'll leave this PR until I have this sorted out so it can be used as reference for the other PR. Thanks! |
|
Please do CC me on the Clang code review, I have thoughts about this but they should be raised in one place. |
|
@rjmccall I added: https://reviews.llvm.org/D66360 but I don't know who to put as the reviewer. Could that just be you? |
|
Yes, just putting me as the reviewer is fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: swiftlang/swift#26658