Make HTTP2StreamChannel generic over a message type #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jul 28, 2020
| @@ -615,7 +621,7 @@ internal extension HTTP2StreamChannel { | |||
| /// | |||
| /// - parameters: | |||
| /// - frame: The `HTTP2Frame` received from the network. | |||
| func receiveInboundFrame(_ frame: HTTP2Frame) { | |||
| func receiveInbound(_ message: Message) { | |||
There was a problem hiding this comment.
I think I'd rather that this didn't change, and instead that we added a line to convert the frame to Message in this method.
| @@ -77,62 +84,80 @@ extension MultiplexerAbstractChannel { | |||
| switch self.baseChannel { | |||
| case .frameBased(let base): | |||
| base.configure(initializer: initializer, userPromise: promise) | |||
| case .payloadBased(let base): | |||
| base.configure(initializer: initializer, userPromise: promise) | |||
There was a problem hiding this comment.
We should fatalError here: we don't ever want this branch to be hit.
8 tasks
Motivation: As part of apple#214 we need to make `HTTP2StreamChannel` generic over the type of message it expects to read and write. This allows us to define an `HTTP2StreamChannel` which uses `HTTP2Frame.FramePayload` as its currency type, rather than `HTTP2Frame`. Modifications: - Make `HTTP2StreamChannel` generic over `Message` which is constrained by conformance to `HTTP2FrameConvertible` and `HTTP2FramePayloadConvertible` - `HTTP2StreamChannel` now expects to read in `Message`s (as opposed to `HTTP2Frame`s) and have `Message`s written in to it. - Added typealiases for frame and payload based stream channels. - Added support for the payload based channel in `MultiplexerAbstractChannel` (although one can't be created yet). Result: We can create payload based stream channels.
glbrntt
force-pushed
the
gb-generic-stream-channel
branch
from
bf8910a to
4b3badc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of #214 we need to make
HTTP2StreamChannelgeneric over the typeof message it expects to read and write. This allows us to define an
HTTP2StreamChannelwhich usesHTTP2Frame.FramePayloadas itscurrency type, rather than
HTTP2Frame.Modifications:
HTTP2StreamChannelgeneric overMessagewhich is constrainedby conformance to
HTTP2FrameConvertibleandHTTP2FramePayloadConvertibleHTTP2StreamChannelnow expects to read inMessages (as opposed toHTTP2Frames) and haveMessages written in to it.MultiplexerAbstractChannel(although one can't be created yet).Result:
We can create payload based stream channels.