Update the test generation script to allow for deprecated tests #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To test deprecated functionality without a bunch of warnings, tests must be marked as deprecated. This also needs to be bubbled up to anywhere calling that test, such as in the generated linux test manifests. Our script to generate the manifests currently doesn't support this and as part of apple#214 we'll need to deprecate a few things while keeping their tests. Modifications: - Pull in the latest version of the `generate_linux_tests.rb` script from SwiftNIO. - Re-run the script, since it includes some formatting changes too. Result: - When we deprecate functionality, we can deprecate the tests without the generate manifests emitting warnings.
PeterAdams-A
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To test deprecated functionality without a bunch of warnings, tests must
be marked as deprecated. This also needs to be bubbled up to anywhere
calling that test, such as in the generated linux test manifests.
Our script to generate the manifests currently doesn't support this and
as part of #214 we'll need to deprecate a few things while keeping their
tests.
Modifications:
generate_linux_tests.rbscriptfrom SwiftNIO.
Result:
the generate manifests emitting warnings.