Feature #853 -w == --write, -W == --suppress-warnings

Also fix maximum snap length
appneta · Jun 29, 2024 · 6a8dbd6 · 6a8dbd6
1 parent 3032e68
commit 6a8dbd6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/docs/CHANGELOG b/docs/CHANGELOG
@@ -1,11 +1,12 @@
-06/23/2024 Version 4.5.0-beta3
+06/29/2024 Version 4.5.0-beta3
     - tcpreplay --include / --exclude to control which packets are replayed (#884)
-    - add -w (--suppress-warnings) option to suppress warning messages (#878)
+    - add -W (--suppress-warnings) option to suppress warning messages (#878)
     - AF_XDP compile issue due to merge issue (#876)
     - memory leak in tcpprep when using include/exclude (#869)
     - memory leak in tcpprep when using RegEx (#867)
     - fix nanosecond timestamp regression bug (#863)
     - autotools - AC_HELP_STRING is obsolete in 2.70 (#856)
+    - add -w output.pcap command line option to direct the output to a pcap (#853)
     - configure.ac: do not run conftest in case of cross compilation (#849)
     - Haiku support (#847)
     - --fixhdrlen option added to control action on packet length changes (#846)

diff --git a/src/common/sendpacket.c b/src/common/sendpacket.c
@@ -847,7 +847,7 @@ sendpacket_open_pcap_dump(const char *device, char *errbuf)
 
     dbg(1, "sendpacket: using Libpcap");
 
-    pcap = pcap_open_dead(DLT_EN10MB, 65535);
+    pcap = pcap_open_dead(DLT_EN10MB, MAX_SNAPLEN);
     if ((dump = pcap_dump_open(pcap, device)) == NULL){
         char* err_msg = pcap_geterr(pcap);
         strlcpy(errbuf, err_msg, PCAP_ERRBUF_SIZE);

diff --git a/src/tcpreplay_opts.def b/src/tcpreplay_opts.def
@@ -265,6 +265,7 @@ flag = {
     value       = i;
     arg-type    = string;
     max         = 1;
+    equivalence = intf1;
     must-set;
     descrip     = "Client to server/RX/primary traffic output interface";
     doc         = <<- EOText
@@ -289,8 +290,8 @@ EOText;
 };
 
 flag = {
-    name        = output;
-    value       = o;
+    name        = write;
+    value       = w;
     arg-type    = string;
     max         = 1;
     equivalence = intf1;
@@ -667,7 +668,6 @@ EOText;
 
 flag = {
     name        = pid;
-    value       = P;
     descrip     = "Print the PID of tcpreplay at startup";
     flag-code   = <<- EOPid
 
@@ -691,7 +691,7 @@ EOText;
 
 flag = {
     name        = suppress-warnings;
-    value       = w;
+    value       = W;
     immediate;
     descrip     = "suppress printing warning messages";
     settable;