feat: advance sort feature #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawaemon
requested changes
Nov 30, 2024
src/bot/meigen/mod.rs
Outdated
Comment on lines
119
to
123
| ArgGroup::new("sort_conflict") | ||
| .args(&["sort"]) | ||
| .requires("sort") | ||
| .conflicts_with("random") | ||
| ))] // --sort and --random conflicts |
There was a problem hiding this comment.
--random --sort love の場合、ランダムにピックして、それらをいいね順にソートして表示 で成立する気がする
src/bot/meigen/mod.rs
Outdated
Comment on lines
131
to
134
| ArgGroup::new("dir_group") | ||
| .args(&["dir"]) | ||
| .requires_all(["sort", "dir"]) | ||
| ))] // --dir requires --sort |
There was a problem hiding this comment.
--sort id がデフォルト値でいいと思う。現在がそうなっているので
src/bot/meigen/mod.rs
Outdated
Comment on lines
169
to
172
| /// 順番を入れ替えます。 | ||
| #[clap(short, long, alias = "rev")] | ||
| #[clap(default_value_t = false)] | ||
| reverse: bool, |
There was a problem hiding this comment.
Suggested change
| /// 順番を入れ替えます。 | |
| #[clap(short, long, alias = "rev")] | |
| #[clap(default_value_t = false)] | |
| reverse: bool, | |
| /// 降順にします。--dir desc のエイリアスです。 | |
| #[clap(short, long, alias = "rev")] | |
| #[clap(default_value_t = false)] | |
| reverse: bool, |
Comment on lines
-219
to
-220
| res.sort_unstable_by_key(|x| x.id); | ||
|
|
|
-r と -R 逆にすれば BC にならなくて良いのでは |
|
ただしい そうする |
|
((trait_ext 赦されたのか)) |
TakeAndApplyIf wasn't used after all, I'm sobbing so hard but nothing beats simplicity
loxygenK
force-pushed
the
feature/advanced-sort-feature
branch
from
68966ba to
0a192a8
Compare
kawaemon
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
つよいソートを実装しました。コンソールでは動いたのでたぶん動きます。MongoDB 上で
loved_user_idがない古い名言データでも動くのを確認しています!Added
--sort=<love|length|id>... ソートをします。fav 数・名言の長さ・ID でソートできます。デフォルト値はidです。--dir=<a|asc|d|desc>... ソート順番を変更します。デフォルトの並び順はソート種類によって異なります。--reversed(--rev,-R) …--dir=descです。Breaking change
ないです！最初はあったけど消えた