chore: Removed unwanted focus test case #38351

sagar-qa007 · 2024-12-24T12:19:43Z

Description

We cover the focus functionality already.

Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38356

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12483068905
Commit: 42b50f9
Cypress dashboard.
Tags: @tag.IDE
Spec:

Tue, 24 Dec 2024 15:13:35 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Chores
- Removed an existing test case for focus retention on specific panes.
Tests
- Renumbered test cases to reflect changes, while maintaining focus retention validation across various components.

coderabbitai · 2024-12-24T12:19:52Z

Walkthrough

The pull request modifies the Focus_retentions_inputs_spec.js test suite by removing a specific test case related to focus retention on various panes and renumbering the remaining test cases accordingly. The adjustments do not change the underlying logic or functionality of the other tests, which continue to validate focus retention behavior across different input components.

Changes

File	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js`	Removed test case "2. Maintains focus on property/Api/Query/Js Pane" and renumbered subsequent test cases.

Possibly Related Issues

[Bug]: Focus retention in the inputs is not consistent #36673: Addresses focus retention inconsistencies, which may relate to the changes made in the test suite.

Possibly Related PRs

fix: Focus retention on inputs #36770: This PR directly modifies the same test suite for focus retention in inputs, updating test descriptions and methods, which aligns closely with the changes made in this PR.

Suggested Labels

skip-changelog, ok-to-test

Suggested Reviewers

ApekshaBhosale
hetunandu

Poem

A test case removed, the numbers rearranged,
In the world of focus, nothing's deranged.
Inputs still hold, as they should in the fray,
A small tweak in tests, on this fine testing day! 🧪✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7880338 and 42b50f9.

📒 Files selected for processing (1)

app/client/cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sagar-qa007 · 2024-12-24T12:20:27Z

/ci-test-limit-count run_count=20 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js

github-actions · 2024-12-24T12:21:01Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12481607004.
Cypress dashboard
PR: #38351 with spec: cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js .

github-actions · 2024-12-24T13:24:17Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12481607004.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 100 Total Passed: 100 Total Failed: 0 Total Skipped: 0 *****************************

sagar-qa007 · 2024-12-24T13:43:00Z

/ci-test-limit-count run_count=20 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js

github-actions · 2024-12-24T13:43:32Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12482487047.
Cypress dashboard
PR: #38351 with spec: cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js .

sagar-qa007 · 2024-12-24T14:40:01Z

/ci-test-limit-count run_count=20 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js runId=12482487047

github-actions · 2024-12-24T14:40:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12483076123.
Cypress dashboard
PR: #38351 with spec: cypress/e2e/Regression/ClientSide/IDE/Focus_retentions_inputs_spec.js .

github-actions · 2024-12-24T14:46:58Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12482487047.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 100 Total Passed: 96 Total Failed: 4 Total Skipped: 0 *****************************

github-actions · 2024-12-24T15:26:52Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12483076123.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 80 Total Passed: 80 Total Failed: 0 Total Skipped: 0 *****************************

Checking failure

7880338

sagar-qa007 requested a review from ApekshaBhosale as a code owner December 24, 2024 12:19

sagar-qa007 changed the title ~~DNM : Checking failure for input focus retentions~~ chore : Removed unwanted focus test case Dec 24, 2024

remove test

42b50f9

sagar-qa007 added the ok-to-test Required label for CI label Dec 24, 2024

sagar-qa007 requested a review from NandanAnantharamu December 25, 2024 04:15

sagar-qa007 changed the title ~~chore : Removed unwanted focus test case~~ chore: Removed unwanted focus test case Dec 25, 2024

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Dec 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Removed unwanted focus test case #38351

chore: Removed unwanted focus test case #38351

sagar-qa007 commented Dec 24, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 24, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sagar-qa007 commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

sagar-qa007 commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

sagar-qa007 commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

chore: Removed unwanted focus test case #38351

Are you sure you want to change the base?

chore: Removed unwanted focus test case #38351

Conversation

sagar-qa007 commented Dec 24, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Dec 24, 2024 • edited Loading

Walkthrough

Changes

Possibly Related Issues

Possibly Related PRs

Suggested Labels

Suggested Reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sagar-qa007 commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

sagar-qa007 commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

sagar-qa007 commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

sagar-qa007 commented Dec 24, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 24, 2024 •

edited

Loading