docs: restructure deploy doc #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenmasters
reviewed
Apr 8, 2020
helenmasters
reviewed
Apr 8, 2020
helenmasters
reviewed
Apr 8, 2020
helenmasters
reviewed
Apr 8, 2020
helenmasters
reviewed
Apr 8, 2020
helenmasters
reviewed
Apr 8, 2020
neeraj-laad
reviewed
Apr 14, 2020
content/docs/faq.md
Outdated
| Their entry is removed from the `project.yaml` file and the associated volumes are deleted. This validation ensures that volumes exist for current projects only and that volumes are not reused between different projects of the same name. | ||
|
|
||
| ## 12. How do I deploy my application to a local Minikube cluster? |
There was a problem hiding this comment.
I don't think this title is right. AFAIK, appsody can deploy to minikube fine - no special config should be needed. Please can you confirm this once?
There was a problem hiding this comment.
The intent was to document how to use Docker daemon from minikube vs Docker on host.
neeraj-laad
requested changes
Apr 14, 2020
content/docs/faq.md
Outdated
| Their entry is removed from the `project.yaml` file and the associated volumes are deleted. This validation ensures that volumes exist for current projects only and that volumes are not reused between different projects of the same name. | ||
|
|
||
| ## 12. How do I deploy my application to a local Minikube cluster? |
There was a problem hiding this comment.
The intent was to document how to use Docker daemon from minikube vs Docker on host.
|
For the FAQ section, |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Restructure "deploying" doc to be clearer
Related Issues
Related to #359
Fixes: appsody/appsody#885
Note: the
### Deploying your application through Docker Huband### Deploying your application to a custom registrysections get fixed as part of #566