-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: try lost pixel #67
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
import { CustomProjectConfig, PageScreenshotParameter } from "lost-pixel"; | ||
|
||
const defaultPageOptions: Partial<PageScreenshotParameter> = { | ||
waitBeforeScreenshot: 2500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be set on top level in lost pixel config! Page config params can help you override the top level ones 😀
|
||
export const config: CustomProjectConfig = { | ||
pageShots: { | ||
pages: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be really cool if we found a way to generate the page list for your DS, recently we added support for programmatic page runs meaning you could generate the array, put it into json and host it statically on your ran website e.g. localhost:3000/pagesToTestWithLP.json and we just pick the info from there ✌🏼
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)