Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setFetchFunction for web #656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SilverMira
Copy link

@SilverMira SilverMira commented May 12, 2023

What does this PR do?

Introduce feature on Web SDK to accept user-defined fetch function when performing request, detailed pitch at #652

Test Plan

I have run the sdk-generator and bundled the generated Web SDK, linked to an existing SvelteKit project as a local package, and was able to reuse fetched responses by the server when SSR is used

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@SilverMira
Copy link
Author

Hi, just dropping by to see if there are any updates, running Appwrite on Sveltekit SSR wouldn't even work properly for authenticated request during load() without this functionality, as the only way to forward auth cookies on the server would be using handleFetch which proxies Sveltekit's special fetch function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant