Feat python type hints #749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used typing because a lot of default python TypeHints are not available until 3.10. On that note, we may need to adjust Python support to 3.8 or later as Typing even has some things that may not work in 3.5.
missed some
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR introduces enhanced type support to the Python SDK
.twigfiles within our codebase. While some types may still be pending, this marks a significant improvement. During testing, I encountered an issue with aModuleNotFoundErrorrelated to 'chardet', followed by anImportErrorlinked to a relocation error in/app/tests/sdks/python/vendor/charset_normalizer/md__mypyc.cpython-39-x86_64-linux-gnu.so.Testing Strategy
For testing, I relied on the existing test suite. An interesting note: my MacBook Pro exhibited unusual heating during testing, the cause of which is unclear. Additionally, the contribution guidelines could benefit from more detailed instructions on individual testing, as I found the current documentation somewhat unclear.
Associated PRs and Issues
This work relates to an issue discussed here: appwrite/sdk-for-python#43.
Acknowledgement of Contribution Guidelines
I have thoroughly read and understood the Contributing Guidelines on issues.
yeeet