Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed file upload for .NET SDK #969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtrcarlos
Copy link

@jtrcarlos jtrcarlos commented Sep 2, 2024

What does this PR do?

This PR includes fixes to the 'CreateFile' flow while using the .NET SDK which was not working.
This changes were applied and tested directly to the SDK and then replicated to this template.

What was done:

  • ignored parameters with no value, which was causing a null object reference
  • fixed the logic regarding the GET method that checks for an already existing file with the same 'fileId'
  • fixed a malformed string (path for the GET method mentioned above)
  • fixed a wrong re-assignment of the 'parameters' variable (used in the GET method mentioned above)

Test Plan

This changes were tested manually by using a locally fixed version of the SDK, using both self-hosted and cloud endpoints.
From what I found, if this is to be tested, it is using PHP, which I don't know.

Files used to test:

  • some .pdf (various sizes)
  • some .png (various sizes)

Related PRs and Issues

Issue #963

Have you read the Contributing Guidelines on issues?

Yes.

@jtrcarlos
Copy link
Author

Issue #963 mentions removing "unique()" check that is missing from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant