Create aip for Aptos Intent Framework #511

runtian-zhou · 2024-10-01T17:39:44Z

No description provided.

ch4r10t33r · 2024-10-02T19:48:22Z

aips/aip-x.md

+Logic here can then be translated into a Move struct that looks like the following:
+```
+struct TradeIntent<Source, phantom Target, Args> has key {
+    offered_resource: Source,


Does dispensable_resource sounds better here?

ch4r10t33r · 2024-10-02T19:52:50Z

aips/aip-x.md

+The `TradeIntent` is parameterized by three type parameters:
+1. `Source`: Value that intent issuer is willing to give away
+2. `Target`: the type of value that the intent issuer is expecting.
+3. `Argument`: Intent user will use `Argument` as auxillary info to determine whether the unlock condition is met.


Are you intending for the argument to be a proof (either zk-proof or storage proof) that can be verified on-chain?

In theory, we could represent the argument as a function f(state, intent) -> bool, where solvers submit proofs for on-chain verification.

In the current design, there's no proof involved: user specifies the post condition the transaction will need to meet, and aptos framework will assert this transaction can only be committed if post condition has been met. Argument is just some auxillary data to help the framework determine whether the transaction can be committed. It would be easier if you look at the move code directly.

ch4r10t33r · 2024-10-02T19:56:10Z

aips/aip-x.md

+
+With those types being generic, we can implement different trading intents easily:
+- If `Target` is instantiated with `FungibleAsset`, it means we are trading a Move value for a specific fungible asset.
+- If `Target` is instantiated with `LinearTransferRef`, it means we are trading a Move value for an Object.


Should we also include NonFungibleAsset as a type? Some DeFi protocols mint NFTs for specific staking or deposit operations, right?

Here are just examples. You can put arbitrary type here.

igor-aptos

You should add a note about this not being published at 0x1.

you can look at https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-72.md#risks-and-drawbacks for what they wrote there, but it could probably be explained a bit more (and the reasons for going that way)

igor-aptos · 2024-10-24T16:13:40Z

aips/aip-x.md

+
+## Summary
+
+Designing a generic mechanism for declaring intents for trading between on chain resources on Aptos. This would allow users to declare which operations they would like to perform upfront and let 3rd party builders to fill in the details on how this transactions should be executed.


this is not necessarily for trading, but for creating offers. (i.e. offer can be more general than a trade)

For example, you could have an offer for a bet.

igor-aptos · 2024-10-24T16:14:21Z

aips/aip-x.md

+
+### Out of scope
+
+We will only be covering the intent declaration and execution logic in the framework. We are not going to touch the solving logic on how intents should be fulfilled and we will leave it for builders on Aptos to figure out.


in the framework => in this AIP

igor-aptos · 2024-10-24T16:29:30Z

aips/aip-x.md

+- It can simplify and speed up cross-chain interactions by pushing risk to "relayers" or "fillers" in exchange for a small fee.
+- Intents are inherently secure, since the outcome signed by the user must match the outcome of the solution. However, ensuring that this is possible typically requires an "intent settlement network".
+
+Intent is a particular concept for Aptos because Move has a unique way of encoding on chain assets. With Move, you can represent


sentence not finished?

igor-aptos · 2024-10-24T16:32:11Z

aips/aip-x.md

+
+Aptos Labs will be responsible for implementing:
+1. A set of intent contracts to ramp up the system.
+2. Framework code for creating and validating intents.


Framework code for creating and validating intents.
=>
Library code for creating and validating intents.

igor-aptos · 2024-10-24T16:39:00Z

aips/aip-x.md

+- If `Target` is instantiated with `LinearTransferRef`, it means we are trading a Move value for an Object.
+- If `Source` is instantiated with `TransferRef`, it means we are giving out ownership to an Object given certain condition.
+- If `Source` is instantiated with `FungibleAsset`, it means we are giving out a certain fungible asset given certain condition.
+   - This doesn't quite work because `FungibleAsset` is not storable. The real implementation would look like giving out ownership of a `FungibleStore`


could this be hidden in the intent? i.e. it stores FungibleStore, but returns extracted FungibleAsset to the caller?

Yes it is currently hidden for implementation.

igor-aptos · 2024-10-24T16:40:26Z

aips/aip-x.md

+```
+User can use this api to register a trading intent to offer a value of `Source` type. The intent can only be executed if anyone can provide a value of `Witness` type. Intent always have an expiry time so that issuer can claim the resource back after the expiry time. Note that the return value of this function is wrapped in an `Object`. This is because we want anyone to be able to claim this intent by providing the address of this object.
+
+Another note is that this procedure is an on-chain procedure. Ideally we should make this a signed message instead so that users don't need to publish this intent to everyone.


this sentence probably goes to future work

igor-aptos · 2024-10-24T16:41:54Z

aips/aip-x.md

+}
+```
+Here we are defining an example of intent where the unlock condition is receiving a certain amount of a given fungible asset type. `Argument` type is instantiated to `FungibleAssetLimitOrder` and `Witness` type is instantated to `FungibleAssetRecipientWitness` in this example. In the arugment, we specify the amount and the type of FA we would like to receive. The check will then be implemented by first checking if the passed in `FungibleAsset` meets the requirement set in the `FungibleAssetLimitOrder` and deposit the FA to the issuer's primary fungible storage if the conditions are met. Once the checks are completed, we will provide the witness `FungibleAssetRecipientWitness` to complete this intent session.
+


this needs an example of snippet of code of what the issuer and settler would need to do , for the above fungible_asset_intent_hooks.

igor-aptos · 2024-10-24T16:42:16Z

aips/aip-x.md

+
+### Example: Defining an intent to receive a certain fungible asset.
+```
+module aptos_framework::fungible_asset_intent_hooks {


it's not aptos_framework , but a different adress

igor-aptos · 2024-10-24T16:49:41Z

aips/aip-x.md

+
+### Frontrun Risk
+
+The intent claiming transaction can be front-runned by malicious mempool operator. Since anyone is able to sign transaction to claim intent solution, a malicous mempool operator can take the intent solving transaction submitted by the solver and sign the same transaction with its own address to be able to claim the lucrative ones. However, since txns usually won't stay too long in the mempool right now, it should not be a major concern at this point. In the future we might need some authentication schema for intent claiming process.


I would rephrase this:

As the system is first-come first-serve, the intent claiming transaction can be front-runned by whoever sees it - mempool operator, validator operator, etc. Since anyone is able to sign transaction to claim intent solution, anyone can take the intent solving transaction submitted by the solver and sign the same transaction with its own address to be able to claim the lucrative ones. If main value comes from finding the route, and not being willing to settle, privacy of submitted transactions will become imporatnt. Intent Solver might want to run a validator node or partner with validator operator. Additionally in the future, support for "secret transactions" , that are revealed only at the time of execution might be added.

igor-aptos · 2024-10-24T16:50:09Z

aips/aip-x.md

+- We need offchain declaration of the intents
+- We can use this standard to incentivize for a credit score system for different DeFi lending protocol:
+    - Implement borrow/lending action as an NFT, and implement scoring system for the NFT as the consumption condition.
+


"secret transactions"

runtian-zhou · 2024-10-30T22:01:06Z

Update the PR with @igor-aptos's comments

Create aip for Aptos Intent Framework

01e5982

ch4r10t33r reviewed Oct 2, 2024

View reviewed changes

runtian-zhou added 3 commits October 2, 2024 15:59

Update aip-x.md

c40a205

Update aip-x.md

4cbaebb

Update aip-x.md

0648118

igor-aptos requested changes Oct 24, 2024

View reviewed changes

Update aip-x.md

b59d56f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create aip for Aptos Intent Framework #511

Create aip for Aptos Intent Framework #511

runtian-zhou commented Oct 1, 2024

ch4r10t33r Oct 2, 2024

ch4r10t33r Oct 2, 2024 •

edited

Loading

runtian-zhou Oct 2, 2024

ch4r10t33r Oct 2, 2024 •

edited

Loading

runtian-zhou Oct 2, 2024

igor-aptos left a comment

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

runtian-zhou Oct 30, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

igor-aptos Oct 24, 2024

runtian-zhou commented Oct 30, 2024


		## Summary

		Designing a generic mechanism for declaring intents for trading between on chain resources on Aptos. This would allow users to declare which operations they would like to perform upfront and let 3rd party builders to fill in the details on how this transactions should be executed.


		### Out of scope

		We will only be covering the intent declaration and execution logic in the framework. We are not going to touch the solving logic on how intents should be fulfilled and we will leave it for builders on Aptos to figure out.


		### Frontrun Risk

		The intent claiming transaction can be front-runned by malicious mempool operator. Since anyone is able to sign transaction to claim intent solution, a malicous mempool operator can take the intent solving transaction submitted by the solver and sign the same transaction with its own address to be able to claim the lucrative ones. However, since txns usually won't stay too long in the mempool right now, it should not be a major concern at this point. In the future we might need some authentication schema for intent claiming process.

Create aip for Aptos Intent Framework #511

Are you sure you want to change the base?

Create aip for Aptos Intent Framework #511

Conversation

runtian-zhou commented Oct 1, 2024

Choose a reason for hiding this comment

ch4r10t33r Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ch4r10t33r Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

igor-aptos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

runtian-zhou commented Oct 30, 2024

ch4r10t33r Oct 2, 2024 •

edited

Loading

ch4r10t33r Oct 2, 2024 •

edited

Loading