Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for publishing large packages to PackagePublisher #36

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support for publishing large packages to PackagePublisher #36

wants to merge 6 commits into from

Conversation

0xjunha
Copy link
Contributor

@0xjunha 0xjunha commented Oct 10, 2024

Description

Note: The integration test will fail on localnet due to a dependency on this PR, which updates the function argument type in the large_packages.move module.

Note: Since the PackagePublisher doesn't include a Move compilation feature, users may face inconvenience having to manually derive object addresses where the large package will be deployed, as shown in the examples/large_package_publisher.py example.

  • Updated large_packages Move module address
  • Downsized chunk size to 60KB
  • Made methods in PackagePublisher reusable in examples
  • Added object deployment and upgrade options for chunked publishing
  • Updated large_package_publisher example

Test Plan

make integration_test

Related Links

davidiw
davidiw reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still draft, let me know when it is ready for review.

@0xjunha
Add support for publishing large packages to PackagePublisher
18efe23 
- Updated `large_packages` Move module address
- Downsized chunk size to 60KB
- Made methods in PackagePublisher reusable in examples
- Added object deployment and upgrade options for chunked publishing
- Updated `large_package_publisher` example
@0xjunha
Update large_packages.move module address
728f643
@0xjunha
Add function docs
e5c59af
@0xjunha
Refactor package_publisher.py, introducing helper classes
5dd1644
@0xjunha
Add publish_move_package method to PackagePublisher to encapsulat…
e02c989 
…e compiling and publishing processes
@0xjunha
Use compile_and_publish_move_package method in `large_package_publi…
3ab7f8d 
…sher` example
@0xjunha 0xjunha marked this pull request as ready for review October 25, 2024 12:18
@0xjunha 0xjunha requested review from gregnazario and a team as code owners October 25, 2024 12:18
@0xjunha
Copy link
Contributor Author

0xjunha commented Oct 25, 2024

Dependency resolved, and now is ready for review! @davidiw
Some more updates:

  • Refactored the PackagePublisher class:
    • Introduced two helper classes:
      • PublishHelper
      • CompileHelper
  • Added compile_and_publish_move_package method:
    • This encapsulates the process of compiling and publishing Move packages. It supports:
      • Deployment to Account or Object
      • Regular or chunked publishing strategies
  • Updated large_package_publishing example to utilize the compile_and_publish_move_package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw left review comments

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xjunha @davidiw