Add gasProfile() method to run Move gas profiling
#584
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
force-pushed
the
add_replay_gas_profiling
branch
from
d54c68c
to
c1190d0
Compare
gregnazario
approved these changes
Nov 18, 2024
Comment on lines
+313
to
+320
| async gasProfile(args: { | ||
| network: string; | ||
| transactionId: string; | ||
| extraArguments?: Array<string>; | ||
| showStdout?: boolean; | ||
| }): Promise<{ output: string; result?: any }> { | ||
| const { network, transactionId, extraArguments, showStdout } = args; | ||
| const cliArgs = ["aptos", "move", "replay", "--profile-gas", "--network", network, "--txn-id", transactionId]; |
There was a problem hiding this comment.
Oh interesting didn't know it works on historical transactions.
Maybe rename it to gasProfileExistingTransaction or something like that?
Or just leave room in this function to take a different input that also allows gas profiling new transactions.
There was a problem hiding this comment.
Oh interesting didn't know it works on historical transactions.
Maybe rename it to gasProfileExistingTransaction or something like that?
Or just leave room in this function to take a different input that also allows gas profiling new transactions.
hmm wdym? the command profiling a committed transaction
aptos move replay --profile-gas --help
Replay a comitted transaction using a local VM
Usage: aptos move replay [OPTIONS] --network <NETWORK> --txn-id <TXN_ID>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Related Links
Checklist
pnpm fmt?CHANGELOG.md?