Enable lint

aptos-labs · Aug 28, 2023 · 4a04080 · 4a04080
1 parent d1f4c2b
commit 4a04080
Show file tree

Hide file tree

Showing 66 changed files with 85 additions and 112 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -3,14 +3,16 @@ module.exports = {
   // this should be just temporary.
   env: {browser: true, es2020: true},
   extends: [
-    // 'eslint:recommended',
-    // 'plugin:@typescript-eslint/recommended',
+    "plugin:@typescript-eslint/recommended",
     "plugin:react-hooks/recommended",
   ],
   parser: "@typescript-eslint/parser",
   parserOptions: {ecmaVersion: "latest", sourceType: "module"},
   // plugins: ['react-refresh'],
   rules: {
     // 'react-refresh/only-export-components': 'warn',
+    // TODO: Remove these exceptions once we have better guards
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-non-null-asserted-optional-chain': 'off'
   },
 };
diff --git a/src/api/hooks/useGetANS.ts b/src/api/hooks/useGetANS.ts
@@ -30,7 +30,7 @@ export function useGetNameFromAddress(
   shouldCache = false,
   isValidator = false,
 ) {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const queryResult = useQuery<string | null, ResponseError>({
     queryKey: ["ANSName", address, shouldCache, state.network_name],
     queryFn: () => {

diff --git a/src/api/hooks/useGetAccount.ts b/src/api/hooks/useGetAccount.ts
@@ -5,7 +5,7 @@ import {ResponseError} from "../client";
 import {useGlobalState} from "../../global-config/GlobalConfig";
 
 export function useGetAccount(address: string) {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   const result = useQuery<Types.AccountData, ResponseError>(
     ["account", {address}, state.network_value],

diff --git a/src/api/hooks/useGetAccountModule.ts b/src/api/hooks/useGetAccountModule.ts
@@ -8,7 +8,7 @@ export function useGetAccountModule(
   address: string,
   moduleName: string,
 ): UseQueryResult<Types.MoveModuleBytecode, ResponseError> {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   return useQuery<Types.MoveModuleBytecode, ResponseError>(
     ["accountModule", {address, moduleName}, state.network_value],

diff --git a/src/api/hooks/useGetAccountModules.ts b/src/api/hooks/useGetAccountModules.ts
@@ -7,7 +7,7 @@ import {useGlobalState} from "../../global-config/GlobalConfig";
 export function useGetAccountModules(
   address: string,
 ): UseQueryResult<Types.MoveModuleBytecode[], ResponseError> {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   return useQuery<Array<Types.MoveModuleBytecode>, ResponseError>(
     ["accountModules", {address}, state.network_value],

diff --git a/src/api/hooks/useGetAccountResource.ts b/src/api/hooks/useGetAccountResource.ts
@@ -19,7 +19,7 @@ export function useGetAccountResource(
   address: string,
   resource: string,
 ): UseQueryResult<Types.MoveResource, ResponseError> {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   return useQuery<Types.MoveResource, ResponseError>(
     ["accountResource", {address, resource}, state.network_value],

diff --git a/src/api/hooks/useGetAccountResources.ts b/src/api/hooks/useGetAccountResources.ts
@@ -7,7 +7,7 @@ import {useGlobalState} from "../../global-config/GlobalConfig";
 export function useGetAccountResources(
   address: string,
 ): UseQueryResult<Types.MoveResource[], ResponseError> {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   return useQuery<Array<Types.MoveResource>, ResponseError>(
     ["accountResources", {address}, state.network_value],

diff --git a/src/api/hooks/useGetAccountTokens.ts b/src/api/hooks/useGetAccountTokens.ts
@@ -1,8 +1,3 @@
-import {
-  Current_Token_Datas,
-  Current_Token_Datas_V2,
-  Current_Token_Ownerships_V2,
-} from "aptos";
 import {useGlobalState} from "../../global-config/GlobalConfig";
 import {useQuery} from "@tanstack/react-query";
 import {normalizeAddress} from "../../utils";

diff --git a/src/api/hooks/useGetAccountTransactions.ts b/src/api/hooks/useGetAccountTransactions.ts
@@ -9,7 +9,7 @@ export function useGetAccountTransactions(
   start?: number,
   limit?: number,
 ): UseQueryResult<Array<Types.Transaction>, ResponseError> {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   const accountTransactionsResult = useQuery<
     Array<Types.Transaction>,

diff --git a/src/api/hooks/useGetAnalyticsData.ts b/src/api/hooks/useGetAnalyticsData.ts
@@ -70,7 +70,7 @@ export type DailyUserTxnData = {
 };
 
 export function useGetAnalyticsData() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [data, setData] = useState<AnalyticsData>();
 
   useEffect(() => {

diff --git a/src/api/hooks/useGetBlock.ts b/src/api/hooks/useGetBlock.ts
@@ -11,7 +11,7 @@ export function useGetBlockByHeight({
   height: number;
   withTransactions?: boolean;
 }) {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   const result = useQuery<Types.Block, ResponseError>(
     ["block", height, state.network_value],
@@ -28,7 +28,7 @@ export function useGetBlockByVersion({
   version: number;
   withTransactions?: boolean;
 }) {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   const result = useQuery<Types.Block, ResponseError>(
     ["block", version, state.network_value],

diff --git a/src/api/hooks/useGetCoinSupplyLimit.tsx b/src/api/hooks/useGetCoinSupplyLimit.tsx
@@ -56,7 +56,7 @@ async function fetchTotalSupply(
 }
 
 export function useGetCoinSupplyLimit(): number | null {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [totalSupply, setTotalSupply] = useState<number | null>(null);
   const {data: coinInfo} = useGetAccountResource(
     "0x1",

diff --git a/src/api/hooks/useGetDelegationNodeInfo.ts b/src/api/hooks/useGetDelegationNodeInfo.ts
@@ -30,7 +30,7 @@ type DelegationNodeInfoProps = {
 export function useGetDelegationNodeInfo({
   validatorAddress,
 }: DelegationNodeInfoProps): DelegationNodeInfoResponse {
-  const [{aptos_client: client}, _] = useGlobalState();
+  const [{aptos_client: client}] = useGlobalState();
   const {totalVotingPower} = useGetValidatorSet();
 
   const {

diff --git a/src/api/hooks/useGetDelegatorStakeInfo.ts b/src/api/hooks/useGetDelegatorStakeInfo.ts
@@ -7,7 +7,7 @@ export function useGetDelegatorStakeInfo(
   delegatorAddress: Types.Address,
   validatorAddress: Types.Address,
 ) {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [stakes, setStakes] = useState<Types.MoveValue[]>([]);
 
   useEffect(() => {

diff --git a/src/api/hooks/useGetEpochTime.ts b/src/api/hooks/useGetEpochTime.ts
@@ -12,7 +12,7 @@ interface BlockResourceData {
 }
 
 export function useGetEpochTime() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [curEpoch, setCurEpoch] = useState<string>();
   const [lastEpochTime, setLastEpochTime] = useState<string>();
   const [epochInterval, setEpochInterval] = useState<string>();

diff --git a/src/api/hooks/useGetInDevMode.ts b/src/api/hooks/useGetInDevMode.ts
@@ -1,6 +1,6 @@
 import {useGlobalState} from "../../global-config/GlobalConfig";
 
 export function useGetInDevMode(): boolean {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   return state.feature_name && state.feature_name === "dev";
 }
diff --git a/src/api/hooks/useGetInMainnet.ts b/src/api/hooks/useGetInMainnet.ts
@@ -2,6 +2,6 @@ import {useGlobalState} from "../../global-config/GlobalConfig";
 
 // TODO: replace existing mainnet checks across the code base with this hook
 export function useGetInMainnet(): boolean {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   return state.network_name === "mainnet";
 }
diff --git a/src/api/hooks/useGetMostRecentBlocks.ts b/src/api/hooks/useGetMostRecentBlocks.ts
@@ -5,7 +5,7 @@ import {getLedgerInfo, getRecentBlocks} from "..";
 import {Types} from "aptos";
 
 export function useGetMostRecentBlocks(count: number) {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [isLoading, setIsLoading] = useState<boolean>(true);
   const [recentBlocks, setRecentBlocks] = useState<Types.Block[]>([]);
 

diff --git a/src/api/hooks/useGetSearchResults.ts b/src/api/hooks/useGetSearchResults.ts
@@ -30,7 +30,7 @@ export const NotFoundResult: SearchResult = {
 
 export default function useGetSearchResults(input: string) {
   const [results, setResults] = useState<SearchResult[]>([]);
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   const searchText = input.trim();
 

diff --git a/src/api/hooks/useGetStakingRewardsRate.ts b/src/api/hooks/useGetStakingRewardsRate.ts
@@ -9,7 +9,7 @@ interface ConfigurationData {
 }
 
 function useGetStakingConfig() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [rewardsRatePerEpoch, setRewardsRatePerEpoch] = useState<string>();
   const [rewardsRateDenominator, setRewardsRateDenominator] =
     useState<string>();

diff --git a/src/api/hooks/useGetTPS.ts b/src/api/hooks/useGetTPS.ts
@@ -6,7 +6,7 @@ import {useGetTPSByBlockHeight} from "./useGetTPSByBlockHeight";
 import {AnalyticsData, ANALYTICS_DATA_URL} from "./useGetAnalyticsData";
 
 export function useGetTPS() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [blockHeight, setBlockHeight] = useState<number | undefined>();
   const {tps} = useGetTPSByBlockHeight(blockHeight);
 
@@ -27,7 +27,7 @@ export function useGetTPS() {
 }
 
 export function useGetPeakTPS() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [peakTps, setPeakTps] = useState<number>();
 
   useEffect(() => {

diff --git a/src/api/hooks/useGetTransaction.ts b/src/api/hooks/useGetTransaction.ts
@@ -5,7 +5,7 @@ import {ResponseError} from "../../api/client";
 import {useGlobalState} from "../../global-config/GlobalConfig";
 
 export function useGetTransaction(txnHashOrVersion: string) {
-  const [state, _setState] = useGlobalState();
+  const [state] = useGlobalState();
 
   const result = useQuery<Types.Transaction, ResponseError>(
     ["transaction", {txnHashOrVersion}, state.network_value],

diff --git a/src/api/hooks/useGetValidatorSet.ts b/src/api/hooks/useGetValidatorSet.ts
@@ -20,7 +20,7 @@ export interface Validator {
 }
 
 export function useGetValidatorSet() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [totalVotingPower, setTotalVotingPower] = useState<string | null>(null);
   const [numberOfActiveValidators, setNumberOfActiveValidators] = useState<
     number | null

diff --git a/src/api/hooks/useGetValidators.ts b/src/api/hooks/useGetValidators.ts
@@ -1,7 +1,7 @@
 import {useGlobalState} from "../../global-config/GlobalConfig";
 import {useEffect, useState} from "react";
 import {useGetValidatorSet} from "./useGetValidatorSet";
-import {Network, NetworkName} from "../../constants";
+import {Network} from "../../constants";
 import {standardizeAddress} from "../../utils";
 
 const MAINNET_VALIDATORS_DATA_URL =
@@ -36,8 +36,8 @@ export interface GeoData {
   epoch: number;
 }
 
-function useGetValidatorsRawData(network: NetworkName) {
-  const [state, _] = useGlobalState();
+function useGetValidatorsRawData() {
+  const [state] = useGlobalState();
   const [validatorsRawData, setValidatorsRawData] = useState<ValidatorData[]>(
     [],
   );
@@ -85,12 +85,9 @@ function useGetValidatorsRawData(network: NetworkName) {
   return {validatorsRawData};
 }
 
-export function useGetValidators(network?: NetworkName) {
-  const [state] = useGlobalState();
+export function useGetValidators() {
   const {activeValidators} = useGetValidatorSet();
-  const {validatorsRawData} = useGetValidatorsRawData(
-    network ?? state.network_name,
-  );
+  const {validatorsRawData} = useGetValidatorsRawData();
 
   const [validators, setValidators] = useState<ValidatorData[]>([]);
 

diff --git a/src/api/hooks/useGoogleTagManager.ts b/src/api/hooks/useGoogleTagManager.ts
@@ -1,4 +1,4 @@
-import TagManager from "react-gtm-module";
+import TagManager, {DataLayerArgs} from "react-gtm-module";
 
 type GTMParams = {
   events: object;
@@ -12,6 +12,6 @@ export const initGTM = ({events}: GTMParams) => {
   TagManager.initialize(tagManagerArgs);
 };
 
-export const sendToGTM = (dataLayer: Object): void => {
+export const sendToGTM = (dataLayer: DataLayerArgs): void => {
   TagManager.dataLayer(dataLayer);
 };
diff --git a/src/api/hooks/useGraphqlClient.tsx b/src/api/hooks/useGraphqlClient.tsx
@@ -42,7 +42,7 @@ function getGraphqlClient(
 }
 
 export function useGetGraphqlClient() {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [graphqlClient, setGraphqlClient] = useState<
     ApolloClient<NormalizedCacheObject>
   >(getGraphqlClient(state.network_name));
@@ -65,7 +65,7 @@ export function GraphqlClientProvider({children}: GraphqlClientProviderProps) {
 }
 
 export function useGetIsGraphqlClientSupported(): boolean {
-  const [state, _] = useGlobalState();
+  const [state] = useGlobalState();
   const [isGraphqlClientSupported, setIsGraphqlClientSupported] =
     useState<boolean>(getIsGraphqlClientSupportedFor(state.network_name));
 

diff --git a/src/api/hooks/useSubmitTransaction.ts b/src/api/hooks/useSubmitTransaction.ts
@@ -72,16 +72,17 @@ const useSubmitTransaction = () => {
         }
         // transaction failed
         return {...responseOnError, message: response.message};
-      } catch (error: any) {
+      } catch (error) {
         if (error instanceof FailedTransactionError) {
           return {
             transactionSubmitted: true,
             transactionHash: response ? response.hash : "",
             message: error.message,
             success: false,
           };
+        } else if (error instanceof Error) {
+          return {...responseOnError, message: error.message};
         }
-        responseOnError.message = error;
       }
       return responseOnError;
     };

diff --git a/src/components/IndividualPageContent/ContentValue/CurrencyValue.tsx b/src/components/IndividualPageContent/ContentValue/CurrencyValue.tsx
@@ -65,7 +65,7 @@ export default function CurrencyValue({
   fixedDecimalPlaces,
   currencyCode,
 }: CurrencyValueProps) {
-  let number = getFormattedBalanceStr(amount, decimals, fixedDecimalPlaces);
+  const number = getFormattedBalanceStr(amount, decimals, fixedDecimalPlaces);
   if (currencyCode) {
     return (
       <span>

diff --git a/src/components/IndividualPageContent/ContentValue/TimestampValue.tsx b/src/components/IndividualPageContent/ContentValue/TimestampValue.tsx
@@ -26,7 +26,7 @@ export default function TimestampValue({timestamp}: TimestampValueProps) {
   const moment = parseTimestamp(timestamp);
   const timestamp_display = timestampDisplay(moment);
 
-  const copyTimestamp = async (event: React.MouseEvent<HTMLButtonElement>) => {
+  const copyTimestamp = async () => {
     await navigator.clipboard.writeText(timestamp);
 
     setTooltipOpen(true);

diff --git a/src/components/IndividualPageContent/JsonCard.tsx b/src/components/IndividualPageContent/JsonCard.tsx
@@ -45,7 +45,7 @@ export default function JsonCard({
     }
   };
 
-  const copyCard = async (event: React.MouseEvent<HTMLButtonElement>) => {
+  const copyCard = async () => {
     await navigator.clipboard.writeText(jsonData);
 
     setTooltipOpen(true);

diff --git a/src/components/Table/TableTooltip.tsx b/src/components/Table/TableTooltip.tsx
@@ -28,7 +28,7 @@ export default function TableTooltip({children, title}: TableTooltipProps) {
       <Modal open={open} onClose={handleClose}>
         <Box
           sx={{
-            position: "absolute" as "absolute",
+            position: "absolute" as const,
             top: "50%",
             left: "50%",
             transform: "translate(-50%, -50%)",

diff --git a/src/components/TitleHashButton.tsx b/src/components/TitleHashButton.tsx
@@ -48,7 +48,7 @@ function HashButton({hash}: {hash: string}) {
 
   const [tooltipOpen, setTooltipOpen] = useState<boolean>(false);
 
-  const copyAddress = async (_event: React.MouseEvent<HTMLButtonElement>) => {
+  const copyAddress = async () => {
     await navigator.clipboard.writeText(hash);
 
     setTooltipOpen(true);

diff --git a/src/pages/Account/Components/AccountAllTransactions.tsx b/src/pages/Account/Components/AccountAllTransactions.tsx
@@ -8,7 +8,6 @@ import {
   useGetAccountAllTransactionVersions,
 } from "../../../api/hooks/useGetAccountAllTransactions";
 import EmptyTabContent from "../../../components/IndividualPageContent/EmptyTabContent";
-import {Statsig} from "statsig-react";
 import {useLogEventWithBasic} from "../hooks/useLogEventWithBasic";
 
 function RenderPagination({
@@ -62,7 +61,7 @@ export function AccountAllTransactionsWithPagination({
   numPages,
   countPerPage,
 }: AccountAllTransactionsWithPaginationProps) {
-  const [searchParams, _setSearchParams] = useSearchParams();
+  const [searchParams] = useSearchParams();
   const currentPage = parseInt(searchParams.get("page") ?? "1");
   const offset = (currentPage - 1) * countPerPage;