Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support entry function without signer param #563

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

SamuelQZQ
Copy link
Contributor

Some entry function does not have the signer param. We should also support that.

@SamuelQZQ SamuelQZQ requested review from 0xbe1 and jillxuu June 28, 2023 07:03
@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for aptos-explorer ready!

Name Link
🔨 Latest commit 42ad343
🔍 Latest deploy log https://app.netlify.com/sites/aptos-explorer/deploys/649bdb5d1c3c790008e666c5
😎 Deploy Preview https://deploy-preview-563--aptos-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@0xbe1 0xbe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamuelQZQ SamuelQZQ changed the title Support no signer entry function Support entry function without signer param Jun 28, 2023
@jillxuu jillxuu requested a review from kaw2k June 28, 2023 17:03
@SamuelQZQ SamuelQZQ merged commit d7b3fe0 into main Jun 29, 2023
8 checks passed
@SamuelQZQ SamuelQZQ deleted the samuel/support-no-signer-entry-function branch June 29, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants