replace instead of push route when changing tabs for more intuitive navigation #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aptos-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BriungRi
reviewed
Jun 30, 2023
| @@ -29,20 +28,14 @@ type GoBackProps = { | |||
| to?: string; | |||
There was a problem hiding this comment.
If the to behavior is being removed, I think to should be removed from the props so that the API for GoBack behaves as expected. The alternative would be to keep the to behavior in this component
There was a problem hiding this comment.
Oh. I'll just remove the GoBackProps type altogether since it's not used anymore.
BriungRi
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adresses https://aptos-org.slack.com/archives/C040LV2NWQ4/p1688084506980749