Move explorer to fungible assets query #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xmaayan I believe the sdk doesn't support the fungible assets queries? But when they do, let me know because I want to support types here :) |
✅ Deploy Preview for aptos-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Work, work, work, work, work, work |
|
Will followup this PR with a typed query from the sdk |
kaw2k
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the coin balances query to the new fungible assets query, this will include coin v1 and fungible assets as seen in the account below.
http://localhost:3000/account/0x40b880d668a9d68d7d521bec03b92857363339053c28459fdfd8d3d905ff0379/coins?network=testnet
vs
the live version missing the FA coin
https://explorer.aptoslabs.com/account/0x40b880d668a9d68d7d521bec03b92857363339053c28459fdfd8d3d905ff0379/coins?network=testnet