Support nested vector in explorer #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kent-white
reviewed
Mar 1, 2024
| @@ -287,6 +288,7 @@ function RunContractForm({ | |||
| } else return arg; | |||
| }), | |||
| }; | |||
| console.log(payload); | |||
gregnazario
reviewed
Mar 1, 2024
| @@ -277,6 +277,7 @@ function RunContractForm({ | |||
| const type = fnParams[i]; | |||
| if (type.includes("vector")) { | |||
| // when it's a vector<u8>, we support both hex and javascript array format | |||
| console.log(type, arg); | |||
src/utils.ts
Outdated
Comment on lines
188
to
190
| if (isArrayStr(trimmed)) { | ||
| inside = trimmed.slice(1, -1); | ||
| } |
There was a problem hiding this comment.
What's this doing?
Can we put a comment above it?
src/utils.ts
Outdated
| if (result[0] === "[" && result[result.length - 1] === "]") { | ||
| result = result.slice(1, -1); | ||
| // Also works nested [[1, 2], [3, 4]] to [["1", "2"], ["3", "4"]] | ||
| // TODO: Need to type this recursively |
There was a problem hiding this comment.
Isn't this recursive now?
src/utils.ts
Outdated
Comment on lines
195
to
205
| const innerArrayStrs = []; | ||
| let build = ""; | ||
| for (let i = 0; i < inside.length; i++) { | ||
| if (inside[i] === "]") { | ||
| innerArrayStrs.push(build); | ||
| build = ""; | ||
| } else { | ||
| build += inside[i]; | ||
| } | ||
| } | ||
| return innerArrayStrs.map(deserializeVector); |
There was a problem hiding this comment.
This code will have the bracket at the beginning?
But, I guess you call it recursively?
I think this misses, can we make a unit test, I suspect that:
[[blah,blah],[blah,blah]]
Will get to:
[blah, blah], [blah, blah]
Then
innerArrayStrs.push('[blah, blah')
innerArrayStrs.push(',[blah, blah')
Then do that recursively which will return two items
'[blah', 'blah'
'','[blah', 'blah'
✅ Deploy Preview for aptos-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kent-white
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
JSON.parseto handle parsing[]arguments.Previously,
[[abc]]would be parsed as["[abc]"], but really, it should be[["abc"]]`.The noteworthy change here is that quotes must now be used for literals. E.g.
[0xabc]used to be acceptable but now must be specified as["0xabc"]