Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch delegation nodes API call #784

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

BriungRi
Copy link
Contributor

@BriungRi BriungRi commented Aug 20, 2024

This PR attempts to fix the too many requests issue in the Delegation Nodes tab. Uses an immutable Move helper: https://explorer.aptoslabs.com/account/0xafb5ec0d4cc58dbb1034c2a6d977919f50bc2936dc478274d64c08491c119c4a/modules/view/helpers/pool_address_info?network=testnet

Also fixes the "To many requests" copy

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for aptos-explorer ready!

Name Link
🔨 Latest commit 2bec4da
🔍 Latest deploy log https://app.netlify.com/sites/aptos-explorer/deploys/66c4bb2b64c9bb0008846c4f
😎 Deploy Preview https://deploy-preview-784--aptos-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should definitely cut down on the calls. We should in the future get this helper probably in the framework

@gregnazario gregnazario merged commit 463a906 into main Aug 20, 2024
7 checks passed
@gregnazario gregnazario deleted the bl/batch-delegation-nodes branch August 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants