Handles potentially null states for coin balance changes #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aptos-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chiumax
changed the title
chiumax
approved these changes
Sep 25, 2024
| @@ -235,8 +235,8 @@ export function useTransactionBalanceChanges(txn_version: string) { | |||
| ? BigInt(-a.amount) | |||
| : BigInt(a.amount), | |||
| asset: { | |||
| decimals: a.metadata.decimals, | |||
| symbol: a.metadata.symbol, | |||
| decimals: a.metadata?.decimals, | |||
There was a problem hiding this comment.
this causes the page not to crash anymore?
There was a problem hiding this comment.
Yes, the metadata object was null, and there were no error boundaries, so the entire page crashed.
gregnazario
approved these changes
Sep 25, 2024
|
for context, null states can occur when object is deleted in that transaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ying-w found a transaction with both null
owner_addressas well as associatedasset_type. This PR adds null checking and an empty state for that case. Note the asset type on the second row is gone for the amount. Also, the address on the far left is absent. Previously this would just crash the page.