Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribe #1337

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add subscribe #1337

merged 2 commits into from
Oct 28, 2024

Conversation

haseebzaki-07
Copy link
Contributor

Title and Issue number

Title : Subscribe to our newsletter

Issue No. : #1324

Tech Stack : express node.js

Close #1324

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Add WEB3 project
  • Other (specify): _______________

Video (mandatory)

Screenshot 2024-10-27 203849
Screenshot 2024-10-27 204919

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Checklist:(In case of Adding New WEB3 project only)

  • I have made my Commits(of new project) under the Projects folder
  • I have created a helpful and easy to understand README.md
  • i have added the image of my project under asstes/img folder

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a GSSOC'24 extended contributor
  • I'm a Winter of Blockchain(WOB'24) contributor
  • I'm a Hactoberfest'24 contributor

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit a12eb42
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/671e5b8de961510008ae49ce
😎 Deploy Preview https://deploy-preview-1337--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haseebzaki-07

image

maybe the subscribe function is working locally on your machine try to make it global

@haseebzaki-07
Copy link
Contributor Author

haseebzaki-07 commented Oct 27, 2024

sure @apu52 I will do it. It needs the production backend URL and also did you add the EMAIL_USER and EMAIL_PASS fields in the .env file, without it wont work.

Please provide me the production backend URL

@apu52
Copy link
Owner

apu52 commented Oct 28, 2024

@haseebzaki-07 yes i understand. As this is an open source so I am not sharing with u the backend URL here , no worries , i will do that farther , now i am merging your PR

@apu52 apu52 merged commit 201df02 into apu52:main Oct 28, 2024
4 checks passed
@haseebzaki-07
Copy link
Contributor Author

hey @apu52 could you please raise the level of the PR!

@apu52 apu52 added level3 and removed level2 labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Subscribe to our newsletter
2 participants