Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FIXED FOOTER #1255

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: FIXED FOOTER #1255

wants to merge 4 commits into from

Conversation

dhairyagothi
Copy link
Contributor

@dhairyagothi dhairyagothi commented Jul 28, 2024

footer ui change #1160

Title : fixed Footer of website

Issue No. : CLOSES #1160

Code Stack :

Close #1160

Description

Video/Screenshots (mandatory)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 4a91e0b
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66a9bedcebd9d600086c02b8
😎 Deploy Preview https://deploy-preview-1255--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@apu52 apu52 changed the title FIXED FOOTER fix: FIXED FOOTER Jul 29, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhairyagothi

image

For the changes u have made the Website footer in the PC format not looking quiet good .try to implement the responsiveness separately using media query

@apu52 apu52 added the help wanted Extra attention is needed label Jul 29, 2024
@dhairyagothi
Copy link
Contributor Author

After

image

@dhairyagothi
Copy link
Contributor Author

dhairyagothi commented Jul 29, 2024

image

before

@apu52
Copy link
Owner

apu52 commented Aug 2, 2024

@dhairyagothi the previous UI of the footer was quiet cool & looking professional UI , So I don't think there is any changes needed in the alignment changes in the UI of the footer . But if u have any other UI improvements ideas u can implement your ideas here .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: footer ui change
2 participants