Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Position of Night mode button #1541

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

manikdamle
Copy link

@manikdamle manikdamle commented Oct 20, 2024

Title and Issue number

Title :Night mode button was not clearly visible in the navbar

Issue No. : #1430

Code Stack :

Close #<#1430>

Description

Night mode button was not clearly visible in the navbar. It is now visible.

Video/Screenshots (mandatory)

2024-10-20 (1)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit e907950
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/671e0b3be8efe30008c928f2
😎 Deploy Preview https://deploy-preview-1541--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manikdamle! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@manikdamle
Copy link
Author

@apu52 Pls review

@manikdamle manikdamle changed the title Position of Night mode button Fix: Position of Night mode button Oct 20, 2024
@manikdamle manikdamle changed the title Fix: Position of Night mode button fix: Position of Night mode button Oct 20, 2024
@manikdamle
Copy link
Author

Hey @apu52 , can you pls review and merge if everything is ok?

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manikdamle this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr

@apu52 apu52 added the help wanted Extra attention is needed label Oct 26, 2024
@manikdamle
Copy link
Author

@apu52 resolved them. Pls check

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recording.2024-10-28.202400.mp4

the changes u have made due to that the hamburger icon in the small width screen of the website does not working due to overlapping with the theme toggle .please try to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed review requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants