Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved Navigation & Layout for TourGuide’s About Page #1603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kartikeyg0104
Copy link

Description:
The updated code refines the structure of the TourGuide’s “About Us” page to address several improvements in navigation, layout, and accessibility. Key enhancements include an optimized navigation bar with smoother dropdown behavior and improved accessibility, a more responsive layout for seamless viewing on various devices, and better integration of video and content sections for an immersive user experience.
Changes & Solutions

1.	Optimized Navigation and Dropdowns: Refined navigation links, moved the dropdown menu for Services inside an unordered list for cleaner structure, and adjusted aria attributes for accessibility.
2.	Enhanced Layout for Mobile: Created a responsive layout that adjusts the navigation and content sections on smaller screens.
3.	Button Accessibility: Changed the login and view buttons into grouped a tags styled as buttons for consistent behavior across browsers and improved accessibility.
4.	Background Video Overlay Fix: Adjusted the video layout and added an optional dark overlay if needed for better readability of text on light backgrounds.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 1e43245
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/67225888d1e9360008897f6e
😎 Deploy Preview https://deploy-preview-1603--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kartikeyg0104
Copy link
Author

Sir please merge my pr.

@apu52
Copy link
Owner

apu52 commented Oct 31, 2024

@kartikeyg0104 have u raised any issue for this particular pr ??

@apu52 apu52 changed the title Improved Navigation & Layout for TourGuide’s About Page feat: Improved Navigation & Layout for TourGuide’s About Page Oct 31, 2024
@apu52 apu52 added the help wanted Extra attention is needed label Oct 31, 2024
@apu52 apu52 added the question Further information is requested label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants