This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Add explanatory text to Getting Started section #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserong
force-pushed
the
wip-more-getting-started-deets
branch
from
0be7bc1
to
70f1857
Compare
jecluis
suggested changes
Aug 2, 2023
If publicDomain and ui.publicDomain aren't specified somehow (whether via `--set ...` or `-f values.yaml`), the installation will fail with "Please provide a value for `.Values.publicDomain`" and "Please provide a value for `.Values.ui.publicDomain`". We can at least hint at this need in advance by suggesting to use YOUR_DOMAIN_NAME in both cases. Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-more-getting-started-deets
branch
from
70f1857
to
a692a98
Compare
jecluis
approved these changes
Aug 2, 2023
|
@asettle mind taking a look, given this is going on the website you might have an opinion :) |
This provides a bit more detail about exactly what you're getting yourself into with each of the example deployment methods. Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-more-getting-started-deets
branch
from
a692a98
to
1227530
Compare
|
(Just removed double spaces after periods -- all else is the same) |
asettle
approved these changes
Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a bit more detail about exactly what you're getting yourself into with each of the example deployment methods.
I've also added publicDomain settings to the
helm installinvocation, because those are the minimum things you actually need to set for the install to work.