Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm-lock.yaml #65

Open
knqyf263 opened this issue Nov 14, 2021 · 9 comments
Open

Support pnpm-lock.yaml #65

knqyf263 opened this issue Nov 14, 2021 · 9 comments

Comments

@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 14, 2021

Description

Parse pnpm-lock.yaml so as to extract package names/versions.

Specification:
https://github.com/pnpm/spec/blob/master/lockfile/5.md

Example:
https://github.com/pnpm/pnpm/blob/main/pnpm-lock.yaml

Issue

aquasecurity/trivy#1200

@WorldVirus
Copy link

Hi,
I tried to push a branch for resolving this issue, but I have not access to push new branch

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Dec 3, 2021

You can search how to make Pull Request on GitHub.

@WorldVirus
Copy link

And for creating new PR, I need to push my branch in repository, but i have

remote: Permission to aquasecurity/go-dep-parser.git denied to WorldVirus.
fatal: unable to access 'https://github.com/aquasecurity/go-dep-parser/': The requested URL returned error: 403

@weyert
Copy link

weyert commented Dec 6, 2021

You need fork the repo and then push the branch to your repo and then after you pushed it should be able to make a PR.
See also: https://makeapullrequest.com

@WorldVirus
Copy link

I opened new pr, but could not update the reviewers

@eranshapira
Copy link

@WorldVirus any intention on taking it further? I might take it if not.

@itaysk
Copy link

itaysk commented Jun 6, 2022

@eranshapira are you actually going to take it?

@weyert
Copy link

weyert commented Jun 6, 2022

In a different project I have been working on a PNPM lock file parsing, you can find it here:
https://gitlab.com/weyert-tapico/gemnasium/-/commit/4fa4879e1fd5f3f8c26e7e3bfd64e5ecb9bf69dc

Feel free to use it

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Jun 6, 2022

Cool! Do you mind if we ask you to contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants