Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm support #1200

Closed
06kellyjac opened this issue Aug 27, 2021 · 6 comments · Fixed by #2414
Closed

pnpm support #1200

06kellyjac opened this issue Aug 27, 2021 · 6 comments · Fixed by #2414
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v0.30.0

Comments

@06kellyjac
Copy link
Contributor

Currently trivy can find package-lock.json and process it, looking for vulnerabilities. It would be nice if it could process pnpm-lock.yaml files too
@06kellyjac 06kellyjac added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2021
@vafanassieff
Copy link

Agree it would be cool !

@knqyf263 knqyf263 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 5, 2021
@knqyf263 knqyf263 mentioned this issue Nov 14, 2021
Open
@WorldVirus
Copy link

Hi !
I am new in open source. But can I take this issue ?

@knqyf263
Copy link
Collaborator

Sure. We have to develop a parser for pnpm at first. You can refer to other parsers. Please feel free to ask any questions.
aquasecurity/go-dep-parser#65

@IkeLutra
Copy link

@WorldVirus How did get on with this? I would be happy to help as well

@WorldVirus
Copy link

I thought, that somebody already took the issue

@06kellyjac
Copy link
Contributor Author

cc: @eranshapira

@knqyf263 knqyf263 removed the co/npm label May 30, 2022
@itaysk itaysk changed the title pnpm support would be nice pnpm support May 31, 2022
@mycodeself mycodeself mentioned this issue Jun 28, 2022
Merged
6 tasks
@knqyf263 knqyf263 added this to the v0.30.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v0.30.0
Development

Successfully merging a pull request may close this issue.

feat(nodejs): add pnpm support mycodeself/trivy
5 participants
@IkeLutra @knqyf263 @06kellyjac @vafanassieff @WorldVirus