feat: add kas parser #143
Open
feat: add kas parser #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nejch
commented
Oct 22, 2022
| @@ -22,6 +22,7 @@ require ( | |||
| github.com/hashicorp/go-cleanhttp v0.5.1 // indirect | |||
| github.com/liamg/jfather v0.0.7 // indirect | |||
| github.com/pmezard/go-difflib v1.0.0 // indirect | |||
| github.com/whilp/git-urls v1.0.0 // indirect | |||
There was a problem hiding this comment.
Not sure how you'll feel about adding this little package. But still seemed better than manually parsing, especially if more git-based parsers are added later.
Comment on lines
+54
to
+57
| version := repo.RefSpec | ||
| if version == "" { | ||
| version = "latest" | ||
| } |
There was a problem hiding this comment.
I add the latest here because without a refspec, it will clone HEAD (like implicit latest in docker), so just wanted to ensure this still gets picked up for BOMs etc.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of adding a few git-based dependencies to trivy - see aquasecurity/trivy#3067. There is more context there, I'm not sure if this is the right place for a git-based parser so I'm happy to make changes, even if this code should live in another repo etc :)
An example real life kas file:
https://github.com/siemens/meta-iot2050/blob/master/kas/iot2050.yml
This PR is largely based on the pnpm parser PR as that had a similar yaml parser, though kas config files are even simpler.
I'll follow up on the trivy side with an analyzer, if this makes sense.