Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): use Name and Version fields if present #290

Conversation

DmitriyLewen
Copy link
Collaborator

@DmitriyLewen DmitriyLewen commented Feb 1, 2024

Description

Dependency name may be present in dependencyPath or Name field - https://github.com/pnpm/spec/blob/274ff02de23376ad59773a9f25ecfedd03a41f64/lockfile/6.0.md#packagesdependencypathname
Same for Versions.
So we can check Name and Version fields instead of checkingResolution.

Related Issues:

@DmitriyLewen DmitriyLewen self-assigned this Feb 1, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review February 1, 2024 09:32
@knqyf263 knqyf263 merged commit 4f19ab4 into aquasecurity:main Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants