Fix parsing and comparing versions with build information #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regex is pretty complex and I don't grok it all. I found that removing the last
?
allows expected results when build information is present, and does not break any existing scenarios covered by unit tests.With 2
?
's, regex101 describes this asvs with 1
?
:Additionally I added multiple test cases to validate build information being handled as expected. Per the semver spec, "Build metadata MUST be ignored when determining version precedence" - added test cases verify that it is in fact ignored as expected.
fixes #7