Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: APP-2462 - Header DAO dropdown fixes #1065

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix: APP-2462 - Header DAO dropdown fixes #1065

merged 1 commit into from
Oct 12, 2023

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Oct 11, 2023 •
edited
Loading

Description

  • Bumps the ODS version in order to pick up changes to the Header DAO dropdown component styling

NOTE: This is currently waiting on aragon/gov-ui-kit#36 to be merged.

Task: APP-2462

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@cgero-eth
Copy link
Member

@Fabricevladimir Version 0.3 of ODS introduces React v18, we'll first need to merge this PR to support the new library version

@Fabricevladimir
Copy link
Contributor Author

@Fabricevladimir Version 0.3 of ODS introduces React v18, we'll first need to merge this PR to support the new library version

You are correct. Nice catch 👍🏾

@Fabricevladimir Fabricevladimir marked this pull request as ready for review October 12, 2023 15:08
cgero-eth
cgero-eth approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Fabricevladimir Fabricevladimir merged commit 1a988b6 into develop Oct 12, 2023
4 of 5 checks passed
@Fabricevladimir Fabricevladimir deleted the fix/app-2462 branch October 12, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabricevladimir @cgero-eth