court: drop redundant areAllJurorsSettled function

aragon · Aug 25, 2019 · 6f4dce2 · 6f4dce2
1 parent 941f72d
commit 6f4dce2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/contracts/Court.sol b/contracts/Court.sol
@@ -696,10 +696,6 @@ contract Court is IJurorsRegistryOwner, ICRVotingOwner, ISubscriptionsOwner, Tim
         return round.filledSeats == round.jurorNumber;
     }
 
-    function areAllJurorsSettled(uint256 _disputeId, uint256 _roundId) public view returns (bool) {
-        return disputes[_disputeId].rounds[_roundId].settledPenalties;
-    }
-
     function canTransitionTerm() public view returns (bool) {
         return neededTermTransitions() >= 1;
     }

diff --git a/test/court-batches.js b/test/court-batches.js
@@ -319,10 +319,10 @@ contract('Court: Batches', ([ rich, arbitrable, juror1, juror2, juror3, juror4,
     it('settles in 2 batches', async () => {
       const batchSize = 4
       await this.court.settleRoundSlashing(disputeId, firstRoundId, batchSize)
-      assert.isFalse(await this.court.areAllJurorsSettled.call(disputeId, firstRoundId))
+      assert.isFalse((await this.court.getAdjudicationRound.call(disputeId, firstRoundId))[3])
       const receipt = await this.court.settleRoundSlashing(disputeId, firstRoundId, batchSize)
       assertLogs(receipt, ROUND_SLASHING_SETTLED_EVENT)
-      assert.isTrue(await this.court.areAllJurorsSettled.call(disputeId, firstRoundId))
+      assert.isTrue((await this.court.getAdjudicationRound.call(disputeId, firstRoundId))[3])
     })
   })
 })