Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2977 - Implement AssetTransfer module component #134

Merged
merged 23 commits into from
Apr 10, 2024
Merged

feat: APP-2977 - Implement AssetTransfer module component #134

merged 23 commits into from
Apr 10, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Apr 2, 2024 •
edited by jira bot
Loading

Description

implement AssetTransfer module component with tests and stories

Task: APP-2977

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.

@thekidnamedkd thekidnamedkd requested a review from cgero-eth April 3, 2024 10:40
@thekidnamedkd thekidnamedkd requested a review from cgero-eth April 4, 2024 11:25
@cgero-eth cgero-eth changed the title feat: APP-2977 - implement AssetTransfer module component feat: APP-2977 - Implement AssetTransfer module component Apr 4, 2024
cgero-eth
cgero-eth reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @thekidnamedkd

src/modules/components/asset/assetTransfer/assetTransferAddress/index.ts Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
cgero-eth
cgero-eth reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component looks great now, well done @thekidnamedkd 👏🏻
Left a couple of comments and a question for @Fabricevladimir

src/modules/components/asset/assetTransfer/assetTransfer.stories.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransfer.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.test.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.test.tsx Outdated Show resolved Hide resolved
src/modules/components/asset/assetTransfer/assetTransferAddress/assetTransferAddress.tsx Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd requested a review from cgero-eth April 10, 2024 10:17
cgero-eth
cgero-eth approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thekidnamedkd!

@thekidnamedkd thekidnamedkd merged commit 9697374 into main Apr 10, 2024
4 checks passed
@thekidnamedkd thekidnamedkd deleted the feat/APP-2977 branch April 10, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir left review comments

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thekidnamedkd @Fabricevladimir @cgero-eth