Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2797 - Implement TransactionDataListItem.Structure module component #135

Merged
merged 2 commits into from
Apr 3, 2024
Merged

feat: APP-2797 - Implement TransactionDataListItem.Structure module component #135

merged 2 commits into from
Apr 3, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Apr 3, 2024 •
edited
Loading

Description

NEW PR to resolve unsigned commits issue from dangling stashed commits:

Implement TransactionDataListItem.Structure component + timestamp formatter & block explorer link creation utilities

Task: APP-2797

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.

@thekidnamedkd
Squashed commit of the following:
ece7e60 
commit d27d8ea
Author: KD <[email protected]>
Date:   Wed Apr 3 13:21:23 2024 +0200

    fix: swap out for additonal span tags

commit 2582f01
Author: KD <[email protected]>
Date:   Wed Apr 3 11:15:09 2024 +0200

    fix: remove console.log

commit d215d6e
Merge: 8e1993e 613663c
Author: KD <[email protected]>
Date:   Wed Apr 3 11:05:38 2024 +0200

    Merge branch 'main' of github.com:aragon/ods into feat/APP-2797

commit 8e1993e
Author: KD <[email protected]>
Date:   Wed Apr 3 11:02:28 2024 +0200

    fix: resolve PR convos - spy test, move consts, remove unnecessary checks and styles

commit b02ab99
Author: KD <[email protected]>
Date:   Wed Apr 3 10:14:51 2024 +0200

    chore: update failed state, revise tests

commit 613663c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Apr 2 12:24:38 2024 +0200

    chore: bump express from 4.18.2 to 4.19.2 (#132)

commit 6d1979e
Author: KD <[email protected]>
Date:   Mon Apr 1 08:32:10 2024 +0200

    fix: TransactionStatus export

commit bcce4a4
Merge: cb5edff 1af7dba
Author: KD <[email protected]>
Date:   Sun Mar 31 23:05:35 2024 +0200

    chore: resolve merge conflict - update CHANGELOG

commit cb5edff
Author: KD <[email protected]>
Date:   Sun Mar 31 23:04:16 2024 +0200

    chore: resolve PR conversations - improved readability, block explorer link, new prop naming, etc

commit f9c96de
Author: KD <[email protected]>
Date:   Wed Mar 27 19:51:29 2024 +0100

    chore: rename effective function

commit 680a2b9
Author: KD <[email protected]>
Date:   Wed Mar 27 19:47:22 2024 +0100

    chore: clean up tests

commit a8962c0
Author: KD <[email protected]>
Date:   Wed Mar 27 19:30:59 2024 +0100

    feat: implement PR fixes from convos -- logic cleanup, props, index barrelin, etc

commit 2d7f6c0
Merge: a18eb16 5ed869c
Author: KD <[email protected]>
Date:   Wed Mar 27 13:30:49 2024 +0100

    On feat/APP-2797: pending PR work

commit 5ed869c
Author: KD <[email protected]>
Date:   Wed Mar 27 13:30:49 2024 +0100

    index on feat/APP-2797: a18eb16 chore: clean up tests

commit a18eb16
Author: KD <[email protected]>
Date:   Tue Mar 26 09:47:16 2024 +0100

    chore: clean up tests

commit 18c445d
Author: KD <[email protected]>
Date:   Mon Mar 25 17:02:26 2024 +0100

    chore: prop cleanup + naming

commit b214cff
Author: KD <[email protected]>
Date:   Mon Mar 25 16:37:18 2024 +0100

    fix: prevent layout shift with spinner wrapper, extra cleanup

commit 64e5894
Author: KD <[email protected]>
Date:   Mon Mar 25 13:10:54 2024 +0100

    fix: update test for unix timestamp to pass on remote CI timezone

commit b50ea0c
Author: KD <[email protected]>
Date:   Mon Mar 25 12:17:32 2024 +0100

    chore: improve test coverage for failed cases

commit e230d1c
Merge: 915d27d bd0f4ce
Author: KD <[email protected]>
Date:   Mon Mar 25 11:50:40 2024 +0100

    chore: update CHANGELOG

commit 915d27d
Author: KD <[email protected]>
Date:   Mon Mar 25 11:40:57 2024 +0100

    feat: handle tx status and relationship with tx type

commit 57f4eee
Author: KD <[email protected]>
Date:   Thu Mar 21 19:29:29 2024 +0100

    chore: update CHANGELOG

commit 2919e21
Author: KD <[email protected]>
Date:   Thu Mar 21 19:28:47 2024 +0100

    chore: update index exports

commit a358d8e
Author: KD <[email protected]>
Date:   Thu Mar 21 19:28:01 2024 +0100

    feat: implement transactionDataListItemStructure component
@thekidnamedkd thekidnamedkd changed the title feat: APP-2797 - Implement TransactionDataListItem.Structure module component* feat: APP-2797 - Implement TransactionDataListItem.Structure module component Apr 3, 2024
@thekidnamedkd thekidnamedkd requested a review from cgero-eth April 3, 2024 15:23
@thekidnamedkd thekidnamedkd merged commit 9eaf8aa into main Apr 3, 2024
4 checks passed
@thekidnamedkd thekidnamedkd deleted the feat/APP-2797-squash branch April 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @cgero-eth