Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-3051 - Implement Breadcrumbs module component #141

Merged
merged 14 commits into from
Apr 17, 2024
Merged

feat: APP-3051 - Implement Breadcrumbs module component #141

merged 14 commits into from
Apr 17, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Apr 12, 2024 •
edited by jira bot
Loading

Description

Task: APP-3051

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.

@thekidnamedkd thekidnamedkd marked this pull request as draft April 12, 2024 16:26
@thekidnamedkd thekidnamedkd requested a review from a team April 15, 2024 07:48
@thekidnamedkd thekidnamedkd marked this pull request as ready for review April 15, 2024 07:49
@cgero-eth cgero-eth changed the title feat: APP-3051 - implement Breadcrumb module component feat: APP-3051 - Implement Breadcrumbs module component Apr 16, 2024
cgero-eth
cgero-eth reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @thekidnamedkd 👍🏻

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.test.tsx Outdated Show resolved Hide resolved
cgero-eth
cgero-eth reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left some minor comments 👌🏻
Make sure to also update the branch with the latest changes on develop

src/core/components/breadcrumbs/breadcrumbs.tsx Show resolved Hide resolved
src/core/components/breadcrumbs/breadcrumbs.tsx Outdated Show resolved Hide resolved
src/core/components/breadcrumbs/index.tsx Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd requested a review from cgero-eth April 17, 2024 08:25
cgero-eth
cgero-eth approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@cgero-eth cgero-eth merged commit d06e4f7 into main Apr 17, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat/APP-3051 branch April 17, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @cgero-eth