Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup Dependabot, set Yarn version to v4 #143

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

cgero-eth
Copy link
Member

Description

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team April 23, 2024 08:14
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Corepack + Dependabot will be very handy. Is there anything we can do over on the app with the dependencies? 🙃

@cgero-eth
Copy link
Member Author

LGTM. Corepack + Dependabot will be very handy. Is there anything we can do over on the app with the dependencies? 🙃

Sure we could introduce Dependabot on the App as well, but given that we're rebuilding it I'm not sure if it makes sense to invest time to update old dependencies there. Let's discuss this on the next tech talk anyway because it might be worth it 👌🏻

@cgero-eth cgero-eth merged commit 960630c into main Apr 23, 2024
4 checks passed
@cgero-eth cgero-eth deleted the setup-dependabot branch April 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants