Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.0 #27

Merged
merged 108 commits into from
Oct 16, 2023
Merged

V1.0 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
3eac40c
Remove old components, update dependencies, fix setup
cgero-eth Sep 18, 2023
debdbf3
Base storybook and jest setup
cgero-eth Sep 18, 2023
7338a52
Update index.ts
cgero-eth Sep 18, 2023
439da7e
renamed color alias from ui to neutral
Fabricevladimir Sep 18, 2023
8b87d4d
added spacing css variables
Fabricevladimir Sep 18, 2023
26900c9
Fix broken tests
cgero-eth Sep 18, 2023
77f39f9
initial breakpoints
Fabricevladimir Sep 18, 2023
f0ed192
borderRadius
Fabricevladimir Sep 18, 2023
c078d20
boxShadows
Fabricevladimir Sep 18, 2023
640ed0d
Start implementation of ods icons
cgero-eth Sep 18, 2023
ddba826
box shadow story
Fabricevladimir Sep 18, 2023
d7d149d
Add missing icons
cgero-eth Sep 18, 2023
0fe970e
Implement illustration-object component
cgero-eth Sep 18, 2023
d9f9f09
Implement illustration-human component
cgero-eth Sep 18, 2023
b3b516e
border radius stories
Fabricevladimir Sep 18, 2023
6fd78c8
spacing visuals
Fabricevladimir Sep 18, 2023
b6cf5bd
Use camelCase for file names
cgero-eth Sep 19, 2023
a61f24c
Update design tokens folder structure
cgero-eth Sep 19, 2023
483fa2f
Use border-radiuses from CSS custom properties
cgero-eth Sep 19, 2023
34d8a73
Use box-shadow from CSS custom properties
cgero-eth Sep 19, 2023
7b0e4d3
Simplify classnames on border-radius stories
cgero-eth Sep 19, 2023
46f84d6
Update docs order
cgero-eth Sep 19, 2023
8382d7a
Merge branch 'v1.0' of https://github.com/aragon/ods into v1.0
Fabricevladimir Sep 19, 2023
9ae81a9
border radius fix
Fabricevladimir Sep 19, 2023
1d62df6
color visualizations
Fabricevladimir Sep 19, 2023
3365a65
Use mdx format for border-radius doc
cgero-eth Sep 19, 2023
5b4eadb
shadows mdx doc file
Fabricevladimir Sep 19, 2023
6fbaceb
migrated spacing stories to mdx doc
Fabricevladimir Sep 19, 2023
f6760b2
colors to mdx
Fabricevladimir Sep 19, 2023
b9f8794
Start implementation of button variants
cgero-eth Sep 19, 2023
d80a708
Merge remote-tracking branch 'origin/main' into v1.0
cgero-eth Sep 19, 2023
e87ca8d
Handle disabled states
cgero-eth Sep 19, 2023
0358123
Fix button tests
cgero-eth Sep 19, 2023
8f4e6fe
Split introduction and installation docs
cgero-eth Sep 19, 2023
20c7638
Implement simple spinner component
cgero-eth Sep 19, 2023
e544966
Start implementation of button loading state
cgero-eth Sep 19, 2023
4b22476
Update button story and test
cgero-eth Sep 20, 2023
bc4ee6f
Update folder structure for illustrations, make illustrations take al…
cgero-eth Sep 20, 2023
fa30673
Handle object and objectPosition properties on illustration-human com…
cgero-eth Sep 20, 2023
14b62f1
typography tokens
Fabricevladimir Sep 20, 2023
ecc5c9a
export typography styles
Fabricevladimir Sep 20, 2023
b5f2e9a
Update ipfs-cluster-ctl version on preview workflow
cgero-eth Sep 20, 2023
7407a63
Introduce addon-designs storybook addon
cgero-eth Sep 20, 2023
dd971b7
Align illustration-object type with illustration-human ones
cgero-eth Sep 20, 2023
eeb2b8c
Implement simple test for illustration-object component
cgero-eth Sep 20, 2023
500f630
Add tests to Icon and IllustrationHuman components
cgero-eth Sep 20, 2023
78146e1
fonts and static directory
Fabricevladimir Sep 20, 2023
37ca1dc
font family
Fabricevladimir Sep 20, 2023
1daebbc
hiding in the shadows
Fabricevladimir Sep 20, 2023
39946a4
font family updated
Fabricevladimir Sep 20, 2023
8891e19
Update button component to handle only-icon and min-widths
cgero-eth Sep 20, 2023
e53575e
Update box-shadow on buttons
cgero-eth Sep 20, 2023
1c9a388
Disable button on loading state
cgero-eth Sep 20, 2023
58fa8d2
Handle focus ring styles on button
cgero-eth Sep 20, 2023
c3e69a8
what we do in the shadows
Fabricevladimir Sep 20, 2023
e9d8247
Start implementation of buttons as links
cgero-eth Sep 20, 2023
eb2ccef
Update tests for button component
cgero-eth Sep 21, 2023
3c438d1
Log ipfsResult on preview workflow
cgero-eth Sep 21, 2023
0782e49
Fix button exports
cgero-eth Sep 21, 2023
5fc9760
Fix typography variables and documentation
cgero-eth Sep 21, 2023
1eca9d9
Use processedIpfsResult instead of ipfsResult
cgero-eth Sep 21, 2023
1e589e9
Update preview-deploy workflow to upload storybook build as artifact
cgero-eth Sep 21, 2023
dbff268
Remove unused addon-interactions addon, move design parameters to def…
cgero-eth Sep 21, 2023
72c5e7e
Update storybook-preview-deploy.yml
cgero-eth Sep 21, 2023
99498b5
Update storybook-preview-deploy.yml
cgero-eth Sep 21, 2023
5b70efb
alert inline initial implementation
Fabricevladimir Sep 21, 2023
8d67f21
Debug preview deployment
cgero-eth Sep 21, 2023
0c5640a
Merge branch 'v1.0' of https://github.com/aragon/ods into v1.0
cgero-eth Sep 21, 2023
3b5e1b8
setting local font
Fabricevladimir Sep 21, 2023
5cd722d
alertCard initial implementation
Fabricevladimir Sep 21, 2023
75429e5
Use env.IPFS_HOST_ADDRESS
cgero-eth Sep 21, 2023
b8b2a15
Fix repository variable usage
cgero-eth Sep 21, 2023
94a3888
Finalise link variant of button component
cgero-eth Sep 21, 2023
11fa9c0
alert card tests
Fabricevladimir Sep 21, 2023
3a59895
rename and export alerts
Fabricevladimir Sep 21, 2023
f9c5222
Add Figma link to colors doc
cgero-eth Sep 21, 2023
763ff60
Implement Progress component
cgero-eth Sep 22, 2023
8ec06e4
tailwind utilities
Fabricevladimir Sep 22, 2023
d66be86
added types folder
Fabricevladimir Sep 22, 2023
cda6300
restructured utilities
Fabricevladimir Sep 22, 2023
236eb96
icons with responsive attribute
Fabricevladimir Sep 22, 2023
57978ed
responsive utils tests
Fabricevladimir Sep 22, 2023
f7d8c98
alertInline with responsive icon
Fabricevladimir Sep 22, 2023
ea99e19
alertInline tests
Fabricevladimir Sep 22, 2023
d2335e1
fixed failing alert inline test
Fabricevladimir Sep 22, 2023
b087314
responsive utils tests
Fabricevladimir Sep 22, 2023
0086500
Implement ActionItem component
cgero-eth Sep 22, 2023
59464f8
Enable no-custom-classname eslint rule
cgero-eth Sep 22, 2023
3c2eb18
Add Figma blocks to token primitives
cgero-eth Sep 22, 2023
98ac177
Sort stories alphabetically
cgero-eth Sep 22, 2023
8f68814
Implement tests for <Button /> component
cgero-eth Sep 22, 2023
8bcc3f7
Remove debug code on preview workflow
cgero-eth Sep 25, 2023
e82bc5b
Fix formatting of preview workflow
cgero-eth Sep 25, 2023
74e175e
added white background color to storybook preview
Fabricevladimir Oct 3, 2023
d80a67a
avatar icon and story
Fabricevladimir Oct 3, 2023
8bb0965
Update babel and rollup dependencies
cgero-eth Oct 11, 2023
8e82737
Update @storybook dependencies
cgero-eth Oct 11, 2023
8542db2
Merge remote-tracking branch 'origin/main' into v1.0
cgero-eth Oct 11, 2023
2a512b9
Update NODE_VERSION on project and workflows to 18
cgero-eth Oct 11, 2023
b952984
Move font-face definitions to typography file
cgero-eth Oct 11, 2023
715a63c
Rename responsive file to responsive-utils, use same class instance
cgero-eth Oct 11, 2023
e7beb76
Rename tw file to docs-utils
cgero-eth Oct 11, 2023
603bf0a
Update file names to follow current conventions
cgero-eth Oct 11, 2023
4e05199
Remove breakpoints as not supported by tailwind, update colors and sp…
cgero-eth Oct 13, 2023
8c4431d
Merge remote-tracking branch 'origin/main' into v1.0
cgero-eth Oct 16, 2023
22770a1
Update CHANGELOG.md
cgero-eth Oct 16, 2023
e8cabfe
Run prettier
cgero-eth Oct 16, 2023
44b7435
Make css and fonts available
cgero-eth Oct 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const extendsBase = [
'plugin:import/typescript',
'plugin:jsx-a11y/recommended',
'plugin:react/recommended',
'plugin:react/jsx-runtime',
'plugin:react-hooks/recommended',
'plugin:testing-library/react',
'plugin:tailwindcss/recommended',
Expand All @@ -29,12 +30,12 @@ const rulesBase = {
'brace-style': 'warn',
'prefer-template': 'warn',
'no-useless-concat': 'warn',
'tailwindcss/no-custom-classname': ['off'],
};

const typescriptRules = {
...rulesBase,
'@typescript-eslint/no-explicit-any': 'warn',
'@typescript-eslint/no-empty-interface': 'off',
'@typescript-eslint/prefer-nullish-coalescing': 'warn',
'@typescript-eslint/array-type': ['warn', { default: 'array-simple' }],
'@typescript-eslint/consistent-type-imports': ['warn', { fixStyle: 'inline-type-imports' }],
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/library-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- "*"

env:
NODE_VERSION: 16
NODE_VERSION: 18
NODE_CACHE: "yarn"

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/library-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- major

env:
NODE_VERSION: 16
NODE_VERSION: 18
NODE_CACHE: "yarn"

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/library-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true

env:
NODE_VERSION: 16
NODE_VERSION: 18
NODE_CACHE: "yarn"

jobs:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/storybook-preview-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- synchronize

env:
NODE_VERSION: 16
NODE_VERSION: 18
NODE_CACHE: "yarn"

jobs:
Expand Down Expand Up @@ -41,20 +41,20 @@ jobs:
run: pip install --user pyyaml packaging
- name: Install ipfs-cluster-ctl
run: |
wget https://dist.ipfs.io/ipfs-cluster-ctl/v1.0.0/ipfs-cluster-ctl_v1.0.0_linux-amd64.tar.gz
tar xvfz ipfs-cluster-ctl_v1.0.0_linux-amd64.tar.gz
wget https://dist.ipfs.tech/ipfs-cluster-ctl/v1.0.6/ipfs-cluster-ctl_v1.0.6_linux-amd64.tar.gz
tar xvfz ipfs-cluster-ctl_v1.0.6_linux-amd64.tar.gz
- name: Unpin from IPFS
continue-on-error: true
if: steps.get-deployment.outputs.comment-id != 0
run: |
COMMENT='${{ steps.get-deployment.outputs.comment-body }}'
IFS=" " read -ra array <<< "$COMMENT"
hash=${array[3]}
./ipfs-cluster-ctl/ipfs-cluster-ctl --basic-auth '${{ secrets.IPFS_BASIC_AUTH }}' --host '${{ secrets.IPFS_HOST }}' pin rm $hash
./ipfs-cluster-ctl/ipfs-cluster-ctl --basic-auth '${{ secrets.IPFS_BASIC_AUTH }}' --host '${{ vars.IPFS_HOST_ADDRESS }}' pin rm $hash
- name: Pin on IPFS
id: ipfs-pin
run: |
ipfsResult="$(./ipfs-cluster-ctl/ipfs-cluster-ctl --basic-auth '${{ secrets.IPFS_BASIC_AUTH }}' --host '${{ secrets.IPFS_HOST }}' add -r './storybook-static' | tail -1)"
ipfsResult="$(./ipfs-cluster-ctl/ipfs-cluster-ctl --basic-auth '${{ secrets.IPFS_BASIC_AUTH }}' --host '${{ vars.IPFS_HOST_ADDRESS }}' -s add -r './storybook-static' | tail -1)"
IFS=" " read -ra array <<< "$ipfsResult"
echo "hash=${array[1]}" >> $GITHUB_OUTPUT
- name: Echo url
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/storybook-preview-remove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- closed

env:
NODE_VERSION: 16
NODE_VERSION: 18
NODE_CACHE: "yarn"

jobs:
Expand All @@ -33,7 +33,7 @@ jobs:
COMMENT='${{ steps.get-deployment.outputs.comment-body }}'
IFS=" " read -ra array <<< "$COMMENT"
hash=${array[3]}
./ipfs-cluster-ctl/ipfs-cluster-ctl --basic-auth '${{ secrets.IPFS_BASIC_AUTH }}' --host '${{ secrets.IPFS_HOST }}' pin rm $hash
./ipfs-cluster-ctl/ipfs-cluster-ctl --basic-auth '${{ secrets.IPFS_BASIC_AUTH }}' --host '${{ vars.IPFS_HOST_ADDRESS }}' pin rm $hash
- name: Delete Comment
uses: actions/[email protected]
if: steps.get-deployment.outputs.comment-id != 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/storybook-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- "*"

env:
NODE_VERSION: 16
NODE_VERSION: 18
NODE_CACHE: "yarn"

jobs:
Expand Down
31 changes: 23 additions & 8 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,37 @@
import type { StorybookConfig } from '@storybook/react-webpack5';
import type { RuleSetRule } from 'webpack';

const config: StorybookConfig = {
stories: ['../docs/**/*.@(md|mdx)', '../src/**/*.stories.@(js|jsx|ts|tsx)'],
stories: ['../docs/**/*.@(md|mdx)', '../src/**/*.stories.@(js|jsx|ts|tsx)', '../src/**/*.@(md|mdx)'],
addons: [
'@storybook/addon-links',
'@storybook/addon-essentials',
'@storybook/addon-interactions',
{
name: '@storybook/addon-styling',
options: { postCss: true },
},
{ name: '@storybook/addon-styling', options: { postCss: true } },
'@storybook/addon-designs',
],
framework: {
name: '@storybook/react-webpack5',
options: {},
},
docs: {
autodocs: 'tag',
staticDirs: ['../src/assets'],
webpackFinal: (webpackConfig) => {
// Remove any svg loader already set and use @svgr/webpack to load svgs on Storybook
const svgWebpackRule = webpackConfig.module?.rules?.find((rule) => {
if (rule != null && typeof rule !== 'string' && (rule as RuleSetRule)?.test instanceof RegExp) {
return (rule as Record<string, any>).test?.test('.svg');
}
});

if (typeof svgWebpackRule !== 'string') {
(svgWebpackRule as RuleSetRule).exclude = /\.svg$/;
}

webpackConfig.module?.rules?.push({
test: /\.svg$/,
use: ['@svgr/webpack'],
});

return webpackConfig;
},
};

Expand Down
38 changes: 26 additions & 12 deletions .storybook/preview.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import isPropValid from '@emotion/is-prop-valid';
import type { Preview } from '@storybook/react';
import React from 'react';
import { StyleSheetManager } from 'styled-components';
import '../index.css';

const preview: Preview = {
Expand All @@ -13,18 +10,35 @@ const preview: Preview = {
date: /Date$/,
},
},
options: {
storySort: {
method: 'alphabetical',
order: ['Docs', ['Open Design System', 'Installation'], 'Design Tokens', 'Components'],
},
},
backgrounds: {
default: 'neutral-50',
values: [
{
name: 'neutral-0',
value: 'var(--ods-color-neutral-0)',
},
{
name: 'neutral-50',
value: 'var(--ods-color-neutral-50)',
},
{
name: 'neutral-800',
value: 'var(--ods-color-neutral-800)',
},
],
},
},
decorators: [
(Story) => (
<StyleSheetManager
shouldForwardProp={(propName, elementToBeRendered) =>
typeof elementToBeRendered === 'string' ? isPropValid(propName) : true
}
>
<div className="flex">
<Story />
</div>
</StyleSheetManager>
<div className="flex">
<Story />
</div>
),
],
};
Expand Down
Loading