Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3626): Update ProposalVoting Container/Stage components to correctly update on stage and status changes #330

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Nov 5, 2024

Description

  • The radix-ui accordion does not update the active item when changing the defaultValue property. In order to mark the next stage active as soon as the previous stage is advanced, we need to control the accordion value by using the value and onValueChange accordion properties. Same changes are needed for the ProposalVotingStage component to properly update the default voting-tab when a stage status changes from PENDING to ACTIVE

Task: APP-3626

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team November 5, 2024 10:20
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks for the update! Left one comment for musing.

@cgero-eth cgero-eth changed the title fix(APP-3626): Update ProposalVotingContainer component to support updates on current active stage fix(APP-3626): Update ProposalVoting Container/Stage components to correctly update on stage and status changes Nov 5, 2024
@cgero-eth cgero-eth merged commit fdaceff into main Nov 5, 2024
4 checks passed
@cgero-eth cgero-eth deleted the APP-3626-update-proposal-voting-active-stage branch November 5, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants