Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2612 - Implement InputContainer and InputText components #48

Merged
merged 27 commits into from
Dec 12, 2023
Merged

feat: APP-2612 - Implement InputContainer and InputText components #48

merged 27 commits into from
Dec 12, 2023

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Nov 23, 2023 •
edited
Loading

Description

  • Implement InputContainer and InputText components
  • Correctly format README.md links on Storybook
  • shadow-none utility class to remove shadow on elements

Task: APP-2612

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title WIP: feat: APP-2612 - Implement InputContainer and InputText components feat: APP-2612 - Implement InputContainer and InputText components Nov 23, 2023
@cgero-eth cgero-eth requested a review from a team November 23, 2023 16:36
@cgero-eth cgero-eth marked this pull request as ready for review November 23, 2023 16:36
Fabricevladimir
Fabricevladimir requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! Left a couple of questions and comments

src/components/input/inputContainer/inputContainer.api.ts Show resolved Hide resolved
src/components/index.ts Show resolved Hide resolved
src/components/input/inputContainer/inputContainer.api.ts Show resolved Hide resolved
src/components/input/inputContainer/inputContainer.tsx Show resolved Hide resolved
src/components/input/inputContainer/inputContainer.tsx Outdated Show resolved Hide resolved
src/components/input/inputContainer/inputContainer.tsx Outdated Show resolved Hide resolved
src/components/input/inputContainer/inputContainer.api.ts Outdated Show resolved Hide resolved
src/components/input/inputText/inputText.tsx Outdated Show resolved Hide resolved
src/components/input/useInputProps.ts Show resolved Hide resolved
tailwind.config.js Show resolved Hide resolved
@cgero-eth cgero-eth force-pushed the feat-implement-input-component branch from 3223442 to 35a8fb3 Compare November 29, 2023 08:57
@cgero-eth
Start implementation of InputContainer and InputText components
58029b0
@cgero-eth
Implement input variants
456ef72
@cgero-eth
Extract input utilities into inputContainerUtils file
87f9c6a
@cgero-eth
Correctly handle input labels
d64280a
@cgero-eth
Cleanup useInputProps hook
e8f3250
@cgero-eth
Update CHANGELOG.md
c9e59bc
@cgero-eth
Fix README formatting on Storybook
dcddb41
@cgero-eth
Add tests for input-container component
fd50a76
@cgero-eth
Implement tests for useInputProps hook
82a899c
@cgero-eth
Fix default variant and Tailwind class processing
5a59c98
@cgero-eth
Update CHANGELOG.md
e479852
@cgero-eth
Update inputContainer.tsx
78f01d3
@cgero-eth
Update documentation of InputContainer component
2379089
@cgero-eth
Apply responsive styling
a057517
@cgero-eth
Correctly handle className property on input components
95607f0
@cgero-eth
Update IInputComponentProps to omit type property
b95ca2c
@cgero-eth
Handle critical and warning alert variants on input
c159c62
@cgero-eth
Set default cursor style for disabled inputs
9d9c66b
@cgero-eth
Start handling input length feedback for input components
8bc48a8
@cgero-eth
Update handling of max-length property
da0b08c
@cgero-eth
Add shake animation on max-length
fc40801
@cgero-eth
Move handling of input length to useInputProps hook
98b78ad
@cgero-eth
Update input container tests
db17221
@cgero-eth
Update input tests
051d0d3
@cgero-eth
Update inputContainer.api.ts
76fa695
@cgero-eth cgero-eth force-pushed the feat-implement-input-component branch from b385c39 to ea5c6e6 Compare December 11, 2023 12:24
@cgero-eth cgero-eth merged commit 3bc6e27 into main Dec 12, 2023
5 checks passed
@cgero-eth cgero-eth deleted the feat-implement-input-component branch December 12, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @Fabricevladimir