-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-2619 - Implement InputNumberMax component #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgero-eth
changed the title
WIP: feat: APP-2619 - Implement NumberInputMax component
WIP: feat: APP-2619 - Implement InputNumberMax component
Dec 12, 2023
cgero-eth
force-pushed
the
feat-implement-number-input-max
branch
2 times, most recently
from
December 13, 2023 15:58
80199f8
to
965c3e3
Compare
cgero-eth
force-pushed
the
feat-implement-number-input-max
branch
3 times, most recently
from
January 22, 2024 12:22
a5f8a81
to
7ebc002
Compare
cgero-eth
changed the title
WIP: feat: APP-2619 - Implement InputNumberMax component
feat: APP-2619 - Implement InputNumberMax component
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting stuff! Left a couple of questions/comments
Fabricevladimir
approved these changes
Jan 23, 2024
cgero-eth
force-pushed
the
feat-implement-number-input-max
branch
from
January 23, 2024 14:15
4ef4ab4
to
c93d674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open questions:
InputNumber
andInputNumberMax
components based on the current formatting rulesmax
propertyTask: APP-2619
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.