Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-2619 - Implement InputNumberMax component #54

Merged
merged 15 commits into from
Jan 23, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Dec 12, 2023

Description

  • Implement InputNumberMax component

Open questions:

  • Number formatting: yes, format numbers of the InputNumber and InputNumberMax components based on the current formatting rules
  • Limit max value: yes, limit the value the user can insert based on the max property

Task: APP-2619

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title WIP: feat: APP-2619 - Implement NumberInputMax component WIP: feat: APP-2619 - Implement InputNumberMax component Dec 12, 2023
@cgero-eth cgero-eth force-pushed the feat-implement-number-input-max branch 2 times, most recently from 80199f8 to 965c3e3 Compare December 13, 2023 15:58
@cgero-eth cgero-eth force-pushed the feat-implement-number-input-max branch 3 times, most recently from a5f8a81 to 7ebc002 Compare January 22, 2024 12:22
@cgero-eth cgero-eth changed the title WIP: feat: APP-2619 - Implement InputNumberMax component feat: APP-2619 - Implement InputNumberMax component Jan 22, 2024
@cgero-eth cgero-eth marked this pull request as ready for review January 22, 2024 12:23
@cgero-eth cgero-eth requested review from Fabricevladimir and a team January 22, 2024 12:29
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting stuff! Left a couple of questions/comments

@cgero-eth cgero-eth force-pushed the feat-implement-number-input-max branch from 4ef4ab4 to c93d674 Compare January 23, 2024 14:15
@cgero-eth cgero-eth merged commit bb3a152 into main Jan 23, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat-implement-number-input-max branch January 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants