Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2694 - Implement Toggle and ToggleGroups components #58

Merged
merged 12 commits into from
Jan 12, 2024
Merged

feat: APP-2694 - Implement Toggle and ToggleGroups components #58

merged 12 commits into from
Jan 12, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Jan 8, 2024 •
edited
Loading

Description

  • Implement Toggle and ToggleGroup components
  • Implement testLogger to suppress console errors when needed during tests

Task: APP-2694

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth force-pushed the feat-APP-2694-implement-toggle-component branch from f3b5bbc to 185d2c6 Compare January 8, 2024 12:12
@cgero-eth cgero-eth changed the title WIP: feat: APP-2694 - Implement Toggle and ToggleGroups components feat: APP-2694 - Implement Toggle and ToggleGroups components Jan 9, 2024
@cgero-eth cgero-eth marked this pull request as ready for review January 9, 2024 08:44
@cgero-eth cgero-eth requested review from a team and removed request for a team January 9, 2024 08:45
@cgero-eth cgero-eth marked this pull request as draft January 9, 2024 08:52
@cgero-eth cgero-eth changed the title feat: APP-2694 - Implement Toggle and ToggleGroups components WIP: feat: APP-2694 - Implement Toggle and ToggleGroups components Jan 9, 2024
@cgero-eth cgero-eth changed the title WIP: feat: APP-2694 - Implement Toggle and ToggleGroups components feat: APP-2694 - Implement Toggle and ToggleGroups components Jan 10, 2024
@cgero-eth cgero-eth requested a review from a team January 10, 2024 16:27
@cgero-eth cgero-eth marked this pull request as ready for review January 10, 2024 16:27
@cgero-eth cgero-eth force-pushed the feat-APP-2694-implement-toggle-component branch from ef42687 to c8e8500 Compare January 11, 2024 12:32
Fabricevladimir
Fabricevladimir reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ruggero! Looking goood

src/components/toggles/toggleGroup/toggleGroup.tsx Show resolved Hide resolved
src/components/toggles/toggleGroup/toggleGroup.stories.tsx Show resolved Hide resolved
@cgero-eth cgero-eth merged commit ca6cb7b into main Jan 12, 2024
5 checks passed
@cgero-eth cgero-eth deleted the feat-APP-2694-implement-toggle-component branch January 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @Fabricevladimir