Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly setup library exports and fix CJS build #70

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jan 25, 2024

Description

  • Fix installation command to use the library without tailwindcss
  • Add exports to properly use ESM/CJS library depending on the environment
  • Fix CJS build by removing ESM-only library react-merge-refs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title WIP: fix: Properly setup library exports fix: Properly setup library exports Jan 30, 2024
@cgero-eth cgero-eth marked this pull request as ready for review January 30, 2024 10:09
@cgero-eth cgero-eth requested a review from a team January 30, 2024 10:14
@cgero-eth cgero-eth changed the title fix: Properly setup library exports fix: Properly setup library exports and fix CJS build Feb 6, 2024
@cgero-eth cgero-eth merged commit 2ba0a90 into main Feb 6, 2024
5 checks passed
@cgero-eth cgero-eth deleted the fix-esm-exports branch February 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant