Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-2744 - Implement TextAreaRichText component #71

Merged
merged 18 commits into from
Jan 31, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jan 29, 2024

Description

  • Implement TextAreaRichText component
  • Add wrapperClassName property to InputContainer component to customise the input wrapper
  • Update InputContainer props to accept any HTML div property and support textarea elements
  • Add border-none Tailwind CSS utility class

Task: APP-2744

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth force-pushed the feat-APP-1744-implement-richtext-component branch 2 times, most recently from a9c8855 to 91fdfae Compare January 29, 2024 12:33
@cgero-eth cgero-eth changed the title WIP: feat-APP-2744: Implement TextAreaRichText component feat-APP-2744: Implement TextAreaRichText component Jan 29, 2024
@cgero-eth cgero-eth marked this pull request as ready for review January 29, 2024 14:09
@cgero-eth cgero-eth requested a review from a team January 29, 2024 14:09
@cgero-eth cgero-eth changed the title feat-APP-2744: Implement TextAreaRichText component feat: APP-2744 - Implement TextAreaRichText component Jan 30, 2024
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Left a couple of questions & comments

Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Looking good

@cgero-eth cgero-eth force-pushed the feat-APP-1744-implement-richtext-component branch from c293dac to 28abc72 Compare January 31, 2024 13:45
@cgero-eth cgero-eth merged commit 5f16ce8 into main Jan 31, 2024
5 checks passed
@cgero-eth cgero-eth deleted the feat-APP-1744-implement-richtext-component branch January 31, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants