-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-2744 - Implement TextAreaRichText component #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgero-eth
force-pushed
the
feat-APP-1744-implement-richtext-component
branch
2 times, most recently
from
January 29, 2024 12:33
a9c8855
to
91fdfae
Compare
cgero-eth
changed the title
WIP: feat-APP-2744: Implement TextAreaRichText component
feat-APP-2744: Implement TextAreaRichText component
Jan 29, 2024
cgero-eth
changed the title
feat-APP-2744: Implement TextAreaRichText component
feat: APP-2744 - Implement TextAreaRichText component
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Left a couple of questions & comments
src/components/textAreas/textAreaRichText/textAreaRichTextActions.tsx
Outdated
Show resolved
Hide resolved
src/components/textAreas/textAreaRichText/textAreaRichTextActions.test.tsx
Show resolved
Hide resolved
src/components/textAreas/textAreaRichText/textAreaRichTextActions.test.tsx
Show resolved
Hide resolved
Fabricevladimir
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Looking good
cgero-eth
force-pushed
the
feat-APP-1744-implement-richtext-component
branch
from
January 31, 2024 13:45
c293dac
to
28abc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextAreaRichText
componentwrapperClassName
property toInputContainer
component to customise the input wrapperInputContainer
props to accept any HTML div property and support textarea elementsborder-none
Tailwind CSS utility classTask: APP-2744
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.