Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: APP-2729 - Implement Input Number component #72

Merged
merged 11 commits into from
Jan 31, 2024

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Jan 29, 2024

Description

  • Implements the InputNumber component

Task: APP-2729

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team January 29, 2024 18:20
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @Fabricevladimir! Left some comments and questions

src/components/input/inputNumber/index.ts Outdated Show resolved Hide resolved
src/components/input/inputNumber/inputNumber.tsx Outdated Show resolved Hide resolved
src/components/input/inputNumber/inputNumber.tsx Outdated Show resolved Hide resolved
src/components/input/inputNumber/inputNumber.tsx Outdated Show resolved Hide resolved
src/components/input/inputNumber/inputNumber.tsx Outdated Show resolved Hide resolved
src/components/input/inputNumber/inputNumber.tsx Outdated Show resolved Hide resolved
@Fabricevladimir Fabricevladimir marked this pull request as ready for review January 30, 2024 18:27
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fabricevladimir! ✅

@Fabricevladimir Fabricevladimir merged commit b8639a0 into main Jan 31, 2024
5 checks passed
@Fabricevladimir Fabricevladimir deleted the f/app-2729 branch January 31, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants