Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARA2-85 remove govern server #320

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

nestorbe
Copy link

@nestorbe nestorbe commented Apr 13, 2021

This PR aims to remove the govern-server package from the repository.

This package was also the root for the the docker-compose script, this script was moved to the root folder.

@linear
Copy link

linear bot commented Apr 13, 2021

ARA2-85 remove govern-server

This issue is a result of ARA2-32 which makes govern api query the graph-node directly for dao data, eliminating the needs for govern-server.

I created this issue here so that we would do this work after ARA2-31 and ARA2-32 and also to investigate and make sure govern-server does not have any other functionalities that need to be retained.

For example, currently, the local development setup uses the docker-compose script in govern-server to start the following docker containers locally. So, we may want to retain the docker-compose script before removing govern-server

  • postgres
  • ipfs server
  • ganache
  • graph-node

@nestorbe nestorbe marked this pull request as ready for review April 13, 2021 17:54
@nestorbe nestorbe requested review from nivida and novaknole April 13, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant