rename function

aragon · Aug 27, 2024 · 6def9f4 · 6def9f4
1 parent 5306a73
commit 6def9f4
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/contracts/src/mocks/plugin/extensions/proposal/ProposalMock.sol b/contracts/src/mocks/plugin/extensions/proposal/ProposalMock.sol
@@ -20,4 +20,9 @@ contract ProposalMock is Proposal {
     ) external returns (uint256 proposalId) {}
 
     function canExecute(uint256 proposalId) external returns (bool) {}
+
+    function createProposalId(
+        IDAO.Action[] memory actions,
+        bytes memory metadata
+    ) external returns (uint256) {}
 }
diff --git a/contracts/src/mocks/plugin/extensions/proposal/ProposalUpgradeableMock.sol b/contracts/src/mocks/plugin/extensions/proposal/ProposalUpgradeableMock.sol
@@ -20,4 +20,9 @@ contract ProposalUpgradeableMock is ProposalUpgradeable {
     ) external returns (uint256 proposalId) {}
 
     function canExecute(uint256 proposalId) external returns (bool) {}
+
+    function createProposalId(
+        IDAO.Action[] memory actions,
+        bytes memory metadata
+    ) external returns (uint256) {}
 }
diff --git a/contracts/src/plugin/extensions/proposal/IProposal.sol b/contracts/src/plugin/extensions/proposal/IProposal.sol
@@ -53,7 +53,7 @@ interface IProposal {
     /// @param actions The actions that will be executed after the proposal passes.
     /// @param metadata The custom metadata that is passed when creating a proposal.
     /// @return proposalId The id of the proposal.
-    function getProposalId(
+    function createProposalId(
         IDAO.Action[] memory actions,
         bytes memory metadata
     ) external returns (uint256);

diff --git a/contracts/src/plugin/extensions/proposal/Proposal.sol b/contracts/src/plugin/extensions/proposal/Proposal.sol
@@ -27,7 +27,7 @@ abstract contract Proposal is IProposal, ERC165 {
             type(IProposal).interfaceId ^
                 IProposal.createProposal.selector ^
                 IProposal.canExecute.selector ^
-                IProposal.getProposalId.selector ||
+                IProposal.createProposalId.selector ||
             _interfaceId == type(IProposal).interfaceId ||
             super.supportsInterface(_interfaceId);
     }

diff --git a/contracts/src/plugin/extensions/proposal/ProposalUpgradeable.sol b/contracts/src/plugin/extensions/proposal/ProposalUpgradeable.sol
@@ -33,7 +33,7 @@ abstract contract ProposalUpgradeable is IProposal, ERC165Upgradeable {
             type(IProposal).interfaceId ^
                 IProposal.createProposal.selector ^
                 IProposal.canExecute.selector ^
-                IProposal.getProposalId.selector ||
+                IProposal.createProposalId.selector ||
             _interfaceId == type(IProposal).interfaceId ||
             super.supportsInterface(_interfaceId);
     }