Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configs): remove plugin repos and setups from the lists of addresses #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented May 1, 2024

Description

  • Remove All SetupProxy and SetupImplementation addresses
  • Remove All RepoProxy and RepoImplementation addresses
  • Adapt types

Task ID: OS-1332

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I created tasks to update dependent repositories (OSx, Plugins)
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

@josemarinas
Copy link
Contributor Author

Still to be decided if new version is v1.3.0 or 0.5.0

Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't merge this PR until we will have the next deployment of 1.3.0

@heueristik
Copy link
Contributor

heueristik commented May 2, 2024

Still to be decided if new version is v1.3.0 or 0.5.0

no, I think this config package will have new versions every time we deploy to a new network. Accordingly, we would need to bump to 1.3.1 or 1.3.2 if we deploy somewhere.
Mathias and I thought it is best to have an independent versioning system independent of the osx protocol version.

@clauBv23
Copy link
Contributor

clauBv23 commented May 2, 2024

Maybe out of this PR scope but still related.
Are Goerli and BaseGoerli still needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants