Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(OS-692): adds github release info to checklists #457

Merged
merged 2 commits into from
Sep 13, 2023
Merged

docs(OS-692): adds github release info to checklists #457

merged 2 commits into from
Sep 13, 2023

Conversation

mathewmeconry
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-692

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

heueristik
heueristik suggested changes Aug 31, 2023
View reviewed changes
DEPLOYMENT_CHECKLIST.md Outdated Show resolved Hide resolved
Rekard0
Rekard0 previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment made by @Michael-A-Heuer , LGTM!

@heueristik heueristik merged commit a642c1b into develop Sep 13, 2023
3 checks passed
@heueristik heueristik deleted the f/OS-692 branch September 13, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @Rekard0 @heueristik